[openssl/openssl] ef6d6e: util/wrap.pl.in: Use parentheses so `kill` gets al...

Richard Levitte noreply at github.com
Thu Sep 15 06:44:34 UTC 2022

  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: ef6d6e452dc57ef4a55d7a6ec0693be650009bb5
  Author: Richard Levitte <levitte at openssl.org>
  Date:   2022-09-15 (Thu, 15 Sep 2022)

  Changed paths:
    M util/wrap.pl.in

  Log Message:
  util/wrap.pl.in: Use parentheses so `kill` gets all its arguments

In perl, this may be ambiguous:

    fn (expr1), expr2

Is the comma (which may be `=>` just as well in this case) a separator
between arguments to `fn`, or is it the comma operator, separating the
expressions `fn(expr1)` and `expr2`?  It appears that in this particular
case, perl takes the existing parentheses to mean the latter.  When the
former was intended, extra parentheses are required.

Fixes #19209

Reviewed-by: Dmitry Belyavskiy <beldmit at gmail.com>
Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/19211)

More information about the openssl-commits mailing list