[openssl/openssl] 79eeaf: OpenSSL::config: determine the MSVC target archite...

Richard Levitte noreply at github.com
Thu Sep 29 12:01:40 UTC 2022


  Branch: refs/heads/openssl-3.0
  Home:   https://github.com/openssl/openssl
  Commit: 79eeaf97dd2ab5153875ea92699fe1b421869aa6
      https://github.com/openssl/openssl/commit/79eeaf97dd2ab5153875ea92699fe1b421869aa6
  Author: Richard Levitte <levitte at openssl.org>
  Date:   2022-09-29 (Thu, 29 Sep 2022)

  Changed paths:
    M .github/workflows/windows.yml
    M util/perl/OpenSSL/config.pm

  Log Message:
  -----------
  OpenSSL::config: determine the MSVC target architecture by asking cl

Since cl knows what architecture it builds fore, all depending on what
the user set up, it makes sense to ask it, and use that result primarly,
and only use the POSIX::uname() MACHINE value as a fallback.

Also, this does indeed determine if cl is present or not.

We drop the explicit names in .github/workflows/windows.yml as proof
of concept.

Fixes #19281

Reviewed-by: Hugo Landau <hlandau at openssl.org>
Reviewed-by: Matt Caswell <matt at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/19285)

(cherry picked from commit 0747f94b5f7b7f07f21384507ba1adaea6f99e88)


  Commit: e9dd48486c2c796f3c9e315022c49d5c9edaf1b1
      https://github.com/openssl/openssl/commit/e9dd48486c2c796f3c9e315022c49d5c9edaf1b1
  Author: Richard Levitte <levitte at openssl.org>
  Date:   2022-09-29 (Thu, 29 Sep 2022)

  Changed paths:
    M util/perl/OpenSSL/config.pm

  Log Message:
  -----------
  OpenSSL::config: Fix VMS guesses

The MACHINE value from POSIX::uname() isn't trustworthy at all.
MACHINE names like this has been seen:

    _HP__VMM___(1.67GHz/9.0MB)

Perl's `$Config{archname}` is much more trustworthy, especially since
VMS isn't a multiarch operating system, at least yet.

Reviewed-by: Hugo Landau <hlandau at openssl.org>
Reviewed-by: Matt Caswell <matt at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/19285)

(cherry picked from commit e63f5fdcb2658961f29fe7bed7968c0dcf7328a7)


  Commit: c71728b0d0ceaca5618e6fca2f2f41e6659624f4
      https://github.com/openssl/openssl/commit/c71728b0d0ceaca5618e6fca2f2f41e6659624f4
  Author: Richard Levitte <levitte at openssl.org>
  Date:   2022-09-29 (Thu, 29 Sep 2022)

  Changed paths:
    M util/perl/OpenSSL/config.pm

  Log Message:
  -----------
  OpenSSL::config: Fix trivial bugs

Reviewed-by: Hugo Landau <hlandau at openssl.org>
Reviewed-by: Matt Caswell <matt at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/19285)

(cherry picked from commit 2ba5bffa26c0c4677f48e730628c0b54c31c734c)


Compare: https://github.com/openssl/openssl/compare/ae4fc850a70f...c71728b0d0ce


More information about the openssl-commits mailing list