[openssl/openssl] 2522ab: crypto/cmp: fix CertReqId to use in p10cr transact...

[David von Oheimb]

  Branch: refs/heads/openssl-3.1
  Home:   https://github.com/openssl/openssl
  Commit: 2522ab06c8a6dae62b24be486ed61780f9671895
      https://github.com/openssl/openssl/commit/2522ab06c8a6dae62b24be486ed61780f9671895
  Author: Dr. David von Oheimb <David.von.Oheimb at siemens.com>
  Date:   2023-04-18 (Tue, 18 Apr 2023)

  Changed paths:
    M apps/lib/cmp_mock_srv.c
    M crypto/cmp/cmp_client.c
    M crypto/cmp/cmp_local.h
    M crypto/cmp/cmp_msg.c
    M crypto/cmp/cmp_server.c
    M doc/internal/man3/ossl_cmp_certreq_new.pod
    M test/cmp_client_test.c
    M test/cmp_msg_test.c

  Log Message:
  -----------
  crypto/cmp: fix CertReqId to use in p10cr transactions acc. to RFC 4210

Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove at arm.com>
Reviewed-by: David von Oheimb <david.von.oheimb at siemens.com>
(Merged from https://github.com/openssl/openssl/pull/20298)

(cherry picked from commit 25b18e629d5cab40f88b33fd9ecf0d69e08c7707)


  Commit: c54050dcf14015c54ec64c2716c19dc590b5c3d5
      https://github.com/openssl/openssl/commit/c54050dcf14015c54ec64c2716c19dc590b5c3d5
  Author: Dr. David von Oheimb <David.von.Oheimb at siemens.com>
  Date:   2023-04-18 (Tue, 18 Apr 2023)

  Changed paths:
    M test/testutil/provider.c

  Log Message:
  -----------
  test_get_libctx(): prevent crash when called with NULL provider arg

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb at siemens.com>
(Merged from https://github.com/openssl/openssl/pull/20257)

(cherry picked from commit 40f3a606b1671d417b63a902dab205e7906dbccd)


  Commit: 1f68d0d2eb39a0f19ccea66c50a06c5ea8ec1032
      https://github.com/openssl/openssl/commit/1f68d0d2eb39a0f19ccea66c50a06c5ea8ec1032
  Author: Dr. David von Oheimb <David.von.Oheimb at siemens.com>
  Date:   2023-04-18 (Tue, 18 Apr 2023)

  Changed paths:
    M crypto/cmp/cmp_vfy.c

  Log Message:
  -----------
  ossl_cmp_msg_check_update(): fix two wrong error return values (-1 instead of 0)

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb at siemens.com>
(Merged from https://github.com/openssl/openssl/pull/20257)

(cherry picked from commit 2eb7a11035144b5556b81aa7e8233927165a5880)


  Commit: 88a6567454f7b0589fc1f3307bc90d82f0c535db
      https://github.com/openssl/openssl/commit/88a6567454f7b0589fc1f3307bc90d82f0c535db
  Author: Dr. David von Oheimb <David.von.Oheimb at siemens.com>
  Date:   2023-04-18 (Tue, 18 Apr 2023)

  Changed paths:
    M crypto/cmp/cmp_vfy.c

  Log Message:
  -----------
  CMP check_transactionID_or_nonce(): fix reason code on unmatched recipNonce

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb at siemens.com>
(Merged from https://github.com/openssl/openssl/pull/20257)

(cherry picked from commit 40eea44884dff96ffd753bfe66c025145a69191b)


  Commit: 058bf8df49a190fb098551f6d68240716de268ae
      https://github.com/openssl/openssl/commit/058bf8df49a190fb098551f6d68240716de268ae
  Author: Dr. David von Oheimb <David.von.Oheimb at siemens.com>
  Date:   2023-04-18 (Tue, 18 Apr 2023)

  Changed paths:
    M crypto/cmp/cmp_ctx.c

  Log Message:
  -----------
  cmp_ctx.c: fix wrong comments on OSSL_CMP_CTX_set1_{recipient,issuer}

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb at siemens.com>
(Merged from https://github.com/openssl/openssl/pull/20257)

(cherry picked from commit 56d5c55de779f35d4e66ae4b791ef1488ab1f57a)


  Commit: 0dc4afdc08b954cc22deb3def01b35bbc5c5accd
      https://github.com/openssl/openssl/commit/0dc4afdc08b954cc22deb3def01b35bbc5c5accd
  Author: Dr. David von Oheimb <David.von.Oheimb at siemens.com>
  Date:   2023-04-18 (Tue, 18 Apr 2023)

  Changed paths:
    M crypto/cmp/cmp_server.c

  Log Message:
  -----------
  OSSL_CMP_SRV_process_request(): fix recipNonce on error in subsequent request of a transaction

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb at siemens.com>
(Merged from https://github.com/openssl/openssl/pull/20257)

(cherry picked from commit 7cd91d221f630f18eb2cc5c01c4204e31c0a15aa)


  Commit: e010626e74e4c84b4b064fa0aace445e5279bb5b
      https://github.com/openssl/openssl/commit/e010626e74e4c84b4b064fa0aace445e5279bb5b
  Author: Dr. David von Oheimb <David.von.Oheimb at siemens.com>
  Date:   2023-04-18 (Tue, 18 Apr 2023)

  Changed paths:
    M doc/internal/man3/ossl_cmp_mock_srv_new.pod

  Log Message:
  -----------
  ossl_cmp_mock_srv_new.pod: correct/update names of internal test support functions

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb at siemens.com>
(Merged from https://github.com/openssl/openssl/pull/20257)

(cherry picked from commit 7439661627b8009f69b13c57b7372286e85a2805)


  Commit: 37da6bd1f6f358b47084d6c8b7ce3b8f34207d8d
      https://github.com/openssl/openssl/commit/37da6bd1f6f358b47084d6c8b7ce3b8f34207d8d
  Author: Dr. David von Oheimb <David.von.Oheimb at siemens.com>
  Date:   2023-04-18 (Tue, 18 Apr 2023)

  Changed paths:
    M apps/cmp.c
    M apps/include/cmp_mock_srv.h
    M apps/lib/cmp_mock_srv.c
    M doc/internal/man3/ossl_cmp_mock_srv_new.pod
    M test/cmp_client_test.c

  Log Message:
  -----------
  cmp_client_test.c: add tests for errors reported by server on subsequent requests in a transaction

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb at siemens.com>
(Merged from https://github.com/openssl/openssl/pull/20257)

(cherry picked from commit 154625e1090b18c8c306a6b7a6970dbab185c49d)


  Commit: a3446d12d81f731126f79b94212fa06a2adb9615
      https://github.com/openssl/openssl/commit/a3446d12d81f731126f79b94212fa06a2adb9615
  Author: Dr. David von Oheimb <David.von.Oheimb at siemens.com>
  Date:   2023-04-18 (Tue, 18 Apr 2023)

  Changed paths:
    M crypto/cmp/cmp_client.c

  Log Message:
  -----------
  CMP cert_response(): add missing rejection status on client rejecting new cert

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb at siemens.com>
(Merged from https://github.com/openssl/openssl/pull/20257)

(cherry picked from commit 44e816bd540c8687c1b4995febbde2626a655338)


Compare: https://github.com/openssl/openssl/compare/bf64571916ca...a3446d12d81f