[openssl/openssl] 6799fc: Coverity 1524619: unexpected control flow

Matt Caswell noreply at github.com
Mon Apr 24 10:20:39 UTC 2023


  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 6799fc2409823939cde5b4a0da909e16ef78d3a8
      https://github.com/openssl/openssl/commit/6799fc2409823939cde5b4a0da909e16ef78d3a8
  Author: Matt Caswell <matt at openssl.org>
  Date:   2023-04-24 (Mon, 24 Apr 2023)

  Changed paths:
    M apps/s_client.c

  Log Message:
  -----------
  Coverity 1524619: unexpected control flow

Using "continue" in a do...while(0) loop is pointless. The original intent
was that the loop would continue to a second iteration in this case.

Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/20788)


  Commit: a80840c663e3409203b0235764e53d8624f74cb8
      https://github.com/openssl/openssl/commit/a80840c663e3409203b0235764e53d8624f74cb8
  Author: Matt Caswell <matt at openssl.org>
  Date:   2023-04-24 (Mon, 24 Apr 2023)

  Changed paths:
    M apps/s_client.c

  Log Message:
  -----------
  Replace use of strstr with strchr

It is better to use strchr where we are looking for a single character.

Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/20788)


Compare: https://github.com/openssl/openssl/compare/d748a1c6ac26...a80840c663e3


More information about the openssl-commits mailing list