[openssl/openssl] 33f6ad: Still advance handshake even on an empty write

Matt Caswell noreply at github.com
Wed Aug 2 14:19:17 UTC 2023


  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 33f6ad1724b2f32a370d01b61ef12120a75d8049
      https://github.com/openssl/openssl/commit/33f6ad1724b2f32a370d01b61ef12120a75d8049
  Author: Matt Caswell <matt at openssl.org>
  Date:   2023-08-02 (Wed, 02 Aug 2023)

  Changed paths:
    M ssl/quic/quic_impl.c

  Log Message:
  -----------
  Still advance handshake even on an empty write

A call to SSL_write() with a zero length buffer should still advance the
handshake. Applications (including s_client) may rely on this.

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Hugo Landau <hlandau at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21578)


  Commit: c31f06120fa8411da3cd779dfe881325204745ac
      https://github.com/openssl/openssl/commit/c31f06120fa8411da3cd779dfe881325204745ac
  Author: Matt Caswell <matt at openssl.org>
  Date:   2023-08-02 (Wed, 02 Aug 2023)

  Changed paths:
    M ssl/quic/quic_impl.c

  Log Message:
  -----------
  Ensure SSL_has_pending() always works even before a connection

s_client calls SSL_has_pending() even before the connection has been
established. We expect it to return 0 in this case and not put any errors
on the stack.

We change things so that SSL_has_pending() always returns 0 if there is
no stream available.

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Hugo Landau <hlandau at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21578)


  Commit: 747b51f48338e3b7e53d0b7a87002edefc7e8439
      https://github.com/openssl/openssl/commit/747b51f48338e3b7e53d0b7a87002edefc7e8439
  Author: Matt Caswell <matt at openssl.org>
  Date:   2023-08-02 (Wed, 02 Aug 2023)

  Changed paths:
    M util/quicserver.c

  Log Message:
  -----------
  Correctly keep track of where we are in the quicserver request buffer

If the request comes in in multiple chunks properly keep tract of where
we are.

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Hugo Landau <hlandau at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21578)


Compare: https://github.com/openssl/openssl/compare/a1c87f64dd6d...747b51f48338


More information about the openssl-commits mailing list