[openssl/openssl] e16c01: Fix a leak in an error path when duplicating an OS...

Matt Caswell noreply at github.com
Thu Aug 17 07:08:21 UTC 2023


  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: e16c0103083af676af8c5564bb21585d4574f992
      https://github.com/openssl/openssl/commit/e16c0103083af676af8c5564bb21585d4574f992
  Author: Matt Caswell <matt at openssl.org>
  Date:   2023-08-17 (Thu, 17 Aug 2023)

  Changed paths:
    M crypto/encode_decode/decoder_pkey.c

  Log Message:
  -----------
  Fix a leak in an error path when duplicating an OSSL_DECODER_CTX.

Make sure we free process_data_dest if it is not actually used.

Found by the reproducible error patch in #21668

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove at arm.com>
Reviewed-by: Hugo Landau <hlandau at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21741)


  Commit: 92e3f43aec553145b4d4cbb4dbd3df9658a05bb4
      https://github.com/openssl/openssl/commit/92e3f43aec553145b4d4cbb4dbd3df9658a05bb4
  Author: Matt Caswell <matt at openssl.org>
  Date:   2023-08-17 (Thu, 17 Aug 2023)

  Changed paths:
    M ssl/record/rec_layer_s3.c

  Log Message:
  -----------
  Don't free the prev BIO prematurely

We shouldn't free the prev BIO in ssl_set_new_record_layer until it is
no longer referenced by s->rlayer.rrlnext.

Found by the reproducible error patch in #21668

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove at arm.com>
Reviewed-by: Hugo Landau <hlandau at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21741)


Compare: https://github.com/openssl/openssl/compare/e4d808652b0a...92e3f43aec55


More information about the openssl-commits mailing list