[openssl/openssl] c08b21: Remove the source directory .num targets

Richard Levitte noreply at github.com
Sat Dec 2 10:48:19 UTC 2023


  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: c08b21a2c95c2925e9c7ab11eb667d95e7b1fe3a
      https://github.com/openssl/openssl/commit/c08b21a2c95c2925e9c7ab11eb667d95e7b1fe3a
  Author: Richard Levitte <levitte at openssl.org>
  Date:   2023-12-02 (Sat, 02 Dec 2023)

  Changed paths:
    M Configurations/unix-Makefile.tmpl

  Log Message:
  -----------
  Remove the source directory .num targets

$(SRCDIR)/util/libcrypto.num and $(SRCDIR)/util/libssl.num were made their
own targets to have 'make ordinals' reproduce them (run mknum.pl) only if
needed.

Unfortunately, because the shared library linker scripts depend on these
.num files, we suddenly have mknum.pl run at random times when building.
Furthermore, this created a diamond dependency, which disturbs parallell
building because multiple mknum.pl on the same file could run at the same
time.

This reverts commit 0e55c3ab8d702ffc897c9beb51d19b14b7896182.

Fixes #21999
Partially fixes #22841

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Matt Caswell <matt at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/22890)




More information about the openssl-commits mailing list