[openssl/openssl] d21c59: Fix incomplete error check on BIO_set_accept_name()

Niels Dossche noreply at github.com
Wed Feb 8 14:45:24 UTC 2023


  Branch: refs/heads/openssl-3.0
  Home:   https://github.com/openssl/openssl
  Commit: d21c59efc088b276ec0c0143c93640a227837134
      https://github.com/openssl/openssl/commit/d21c59efc088b276ec0c0143c93640a227837134
  Author: ndossche <niels.dossche at ugent.be>
  Date:   2023-02-08 (Wed, 08 Feb 2023)

  Changed paths:
    M crypto/bio/bss_acpt.c

  Log Message:
  -----------
  Fix incomplete error check on BIO_set_accept_name()

BIO_set_accept_name() can return error values -1 and 0 according to
my analysis tool and the documentation. Documentation says a value of 1
indicates success. Currently, only an error value != 0 is checked which
erroneously interprets a -1 error return value as success.
Fix it by changing the check condition.

CLA: trivial

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: Todd Short <todd.short at me.com>
(Merged from https://github.com/openssl/openssl/pull/20206)

(cherry picked from commit a811b6305b1f98e8ec66b8a426d359150fea69b2)
(cherry picked from commit 510e4935ca728cf91820edcec55afb8e1f6aa5a2)




More information about the openssl-commits mailing list