[openssl/openssl] b2b18a: Fix incomplete error check on BIO_set_md()

Niels Dossche noreply at github.com
Wed Feb 8 15:45:26 UTC 2023


  Branch: refs/heads/openssl-3.0
  Home:   https://github.com/openssl/openssl
  Commit: b2b18abaaa31e7f9008673f57f1d21d32e4d1d9b
      https://github.com/openssl/openssl/commit/b2b18abaaa31e7f9008673f57f1d21d32e4d1d9b
  Author: ndossche <niels.dossche at ugent.be>
  Date:   2023-02-08 (Wed, 08 Feb 2023)

  Changed paths:
    M crypto/cms/cms_lib.c

  Log Message:
  -----------
  Fix incomplete error check on BIO_set_md()

BIO_set_md() can return an error value <= 0 according to my analysis
tool and the documentation. But only an error value == 0 is currently
checked. Fix it by changing the check condition.

CLA: trivial

Reviewed-by: Hugo Landau <hlandau at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Todd Short <todd.short at me.com>
(Merged from https://github.com/openssl/openssl/pull/20195)

(cherry picked from commit abf654645dee168b229f3fa6a365f6a8e4dd7c31)
(cherry picked from commit 9b77bd92f898d7ee6a9f135eb39d84591452f330)




More information about the openssl-commits mailing list