[openssl/openssl] 673671: Fix error check on default_check() helper function

Niels Dossche noreply at github.com
Wed Feb 8 15:58:29 UTC 2023


  Branch: refs/heads/openssl-3.0
  Home:   https://github.com/openssl/openssl
  Commit: 673671c7d5cc37ad66f67bdc2587edbadf17f6a5
      https://github.com/openssl/openssl/commit/673671c7d5cc37ad66f67bdc2587edbadf17f6a5
  Author: ndossche <niels.dossche at ugent.be>
  Date:   2023-02-08 (Wed, 08 Feb 2023)

  Changed paths:
    M crypto/evp/ctrl_params_translate.c

  Log Message:
  -----------
  Fix error check on default_check() helper function

default_check() can return a zero value to indicate an internal error in
one condition for the PRE_CTRL_STR_TO_PARAMS state. This state can be
reached from the default_fixup_args() function which does not check for
a zero value. All other callers of default_check() in that file do check
for a zero return value. Fix it by changing the check to <= 0.

CLA: trivial

Reviewed-by: Hugo Landau <hlandau at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/20175)

(cherry picked from commit 650f0474282330e3eb2a3df0eff5864bbdcf5845)




More information about the openssl-commits mailing list