[openssl/openssl] 6f9e53: CMS_add1_crl(): prevent double free on failure of ...

[David von Oheimb]

  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 6f9e531003fd736e8e96d9a1a57f7763da9722b8
      https://github.com/openssl/openssl/commit/6f9e531003fd736e8e96d9a1a57f7763da9722b8
  Author: Dr. David von Oheimb <David.von.Oheimb at siemens.com>
  Date:   2023-02-24 (Fri, 24 Feb 2023)

  Changed paths:
    M crypto/cms/cms_lib.c

  Log Message:
  -----------
  CMS_add1_crl(): prevent double free on failure of CMS_add0_crl()

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb at siemens.com>
(Merged from https://github.com/openssl/openssl/pull/19199)


  Commit: 65def9de8088ae39d8f251e0b57f1a0f204daa14
      https://github.com/openssl/openssl/commit/65def9de8088ae39d8f251e0b57f1a0f204daa14
  Author: Dr. David von Oheimb <David.von.Oheimb at siemens.com>
  Date:   2023-02-24 (Fri, 24 Feb 2023)

  Changed paths:
    M CHANGES.md
    M crypto/cms/cms_lib.c
    M doc/man3/CMS_add0_cert.pod
    M doc/man3/CMS_sign.pod
    M doc/man3/CMS_verify.pod
    M test/cmsapitest.c

  Log Message:
  -----------
  CMS_add0_cert: if cert already present, do not throw error but ignore it

Also add checks on failing cert/CRL up_ref calls; improve coding style.

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb at siemens.com>
(Merged from https://github.com/openssl/openssl/pull/19199)


Compare: https://github.com/openssl/openssl/compare/ee58915cfd9d...65def9de8088