[openssl/openssl] 7331e7: Padlock: fix byte swapping assembly for AES-192 an...

ValdikSS noreply at github.com
Fri Jan 20 07:34:25 UTC 2023

  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 7331e7ef79fe4499d81cc92249e9c97e9ff9291a
  Author: ValdikSS <iam at valdikss.org.ru>
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
    M engines/asm/e_padlock-x86.pl
    M engines/asm/e_padlock-x86_64.pl

  Log Message:
  Padlock: fix byte swapping assembly for AES-192 and 256

Byte swapping code incorrectly uses the number of AES rounds to swap expanded
AES key, while swapping only a single dword in a loop, resulting in swapped
key and partially swapped expanded keys, breaking AES encryption and
decryption on VIA Padlock hardware.

This commit correctly sets the number of swapping loops to be done.

Fixes #20073

CLA: trivial

Reviewed-by: Hugo Landau <hlandau at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/20077)

More information about the openssl-commits mailing list