[openssl/openssl] 1b24b5: bin2bn(): When len==0, just return a zero BIGNUM

Richard Levitte noreply at github.com
Fri Jan 20 07:41:20 UTC 2023


  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 1b24b5a1b43c2af0a6c1cb2d196f5132ee723488
      https://github.com/openssl/openssl/commit/1b24b5a1b43c2af0a6c1cb2d196f5132ee723488
  Author: Richard Levitte <levitte at openssl.org>
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
    M crypto/bn/bn_lib.c

  Log Message:
  -----------
  bin2bn(): When len==0, just return a zero BIGNUM

This allows calls with s==NULL and len==0 to be safe.  It probably already
was, but address sanitizers could still complain.

Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Hugo Landau <hlandau at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/20033)


  Commit: 15192335c8bbfb78bc02086bcd77a0d82efffbce
      https://github.com/openssl/openssl/commit/15192335c8bbfb78bc02086bcd77a0d82efffbce
  Author: Richard Levitte <levitte at openssl.org>
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
    M test/bntest.c

  Log Message:
  -----------
  Add a test for public variants of bn2bin()

We test with binary input of length 1, length 0, and NULL input with length 0

Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Hugo Landau <hlandau at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/20033)


  Commit: c9466f38e0191aa86e0bd49267b0c4ef33e3a3d2
      https://github.com/openssl/openssl/commit/c9466f38e0191aa86e0bd49267b0c4ef33e3a3d2
  Author: Richard Levitte <levitte at openssl.org>
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
    M crypto/bn/bn_lib.c
    M test/bntest.c

  Log Message:
  -----------
  bn2bin(): Don't accept len < 0

Test included

Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Hugo Landau <hlandau at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/20033)


Compare: https://github.com/openssl/openssl/compare/7331e7ef79fe...c9466f38e019


More information about the openssl-commits mailing list