[openssl/openssl] f52646: Fix incomplete check on X509V3_add1_i2d()

Niels Dossche noreply at github.com
Tue Jan 31 00:09:20 UTC 2023


  Branch: refs/heads/openssl-3.1
  Home:   https://github.com/openssl/openssl
  Commit: f526461da3be0f39190fd5dbe3dd914dab81cf83
      https://github.com/openssl/openssl/commit/f526461da3be0f39190fd5dbe3dd914dab81cf83
  Author: ndossche <niels.dossche at ugent.be>
  Date:   2023-01-31 (Tue, 31 Jan 2023)

  Changed paths:
    M crypto/ocsp/ocsp_ext.c

  Log Message:
  -----------
  Fix incomplete check on X509V3_add1_i2d()

X509V3_add1_i2d() can return both -1 and 0 as an error code. This check
only checked for 0. Change it into <= 0 to also catch the -1 error code.

CLA: trivial

Reviewed-by: Tim Hudson <tjh at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/20157)

(cherry picked from commit ecd445464a73bb3f125327a604dd13ad16303ebc)




More information about the openssl-commits mailing list