[openssl/openssl] 8a7642: Enable QUIC by default

Matt Caswell noreply at github.com
Thu Jul 6 02:57:08 UTC 2023


  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 8a7642023884ccfbb17a929698dab8e3fc03cdc9
      https://github.com/openssl/openssl/commit/8a7642023884ccfbb17a929698dab8e3fc03cdc9
  Author: Matt Caswell <matt at openssl.org>
  Date:   2023-07-06 (Thu, 06 Jul 2023)

  Changed paths:
    M .github/workflows/ci.yml
    M .github/workflows/coveralls.yml
    M .github/workflows/os-zoo.yml
    M .github/workflows/run-checker-ci.yml
    M .github/workflows/windows.yml
    M CHANGES.md
    M Configure
    M INSTALL.md
    M NEWS.md

  Log Message:
  -----------
  Enable QUIC by default

Ensure builds enable QUIC without explicitly having to ask for it. To
disable QUIC pass "no-quic" to Configure.

As a result we can remove all use of "enable-quic" from the various CI
runs.

We also add a CHANGES and NEWS entry for QUIC support.

Reviewed-by: Tim Hudson <tjh at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21332)


  Commit: 0e94bba0df257d47fb9623b9b95ef2b64402fde5
      https://github.com/openssl/openssl/commit/0e94bba0df257d47fb9623b9b95ef2b64402fde5
  Author: Matt Caswell <matt at openssl.org>
  Date:   2023-07-06 (Thu, 06 Jul 2023)

  Changed paths:
    M Configure

  Log Message:
  -----------
  Disable QUIC if TLSv1.3 is disabled

QUIC depends on TLSv1.3, so if the latter is disabled then we must do
the same for QUIC.

Reviewed-by: Tim Hudson <tjh at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21332)


  Commit: 1a2a0e1dc88bf905a7997e12de08a4b45f9db53c
      https://github.com/openssl/openssl/commit/1a2a0e1dc88bf905a7997e12de08a4b45f9db53c
  Author: Matt Caswell <matt at openssl.org>
  Date:   2023-07-06 (Thu, 06 Jul 2023)

  Changed paths:
    M ssl/quic/quic_thread_assist.c

  Log Message:
  -----------
  Don't compile quic_thread_assist.c on OPENSSL_NO_QUIC_THREAD_ASSIST

If OPENSSL_NO_QUIC_THREAD_ASSIST is defined then we don't have the right
support for QUIC thread assisted mode so don't attempt to compile that
code.

Reviewed-by: Tim Hudson <tjh at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21332)


  Commit: 0cea6df239fc5c5c5902b4c660305bf953f03eb1
      https://github.com/openssl/openssl/commit/0cea6df239fc5c5c5902b4c660305bf953f03eb1
  Author: Matt Caswell <matt at openssl.org>
  Date:   2023-07-06 (Thu, 06 Jul 2023)

  Changed paths:
    M ssl/quic/quic_trace.c
    M test/quic_cc_test.c
    M test/quic_multistream_test.c

  Log Message:
  -----------
  Use %llx not %lx for uint64_t

Some compilers don't like %lx

Reviewed-by: Tim Hudson <tjh at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21332)


  Commit: 1be2ee683c3cbd8690728a05e05b778d5f7674b8
      https://github.com/openssl/openssl/commit/1be2ee683c3cbd8690728a05e05b778d5f7674b8
  Author: Matt Caswell <matt at openssl.org>
  Date:   2023-07-06 (Thu, 06 Jul 2023)

  Changed paths:
    M test/quicapitest.c

  Log Message:
  -----------
  Skip the QUIC ssltrace test under certain config options

Various options disturb the output expected from the ssl trace test, so we
skip it if necessary.

Reviewed-by: Tim Hudson <tjh at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21332)


  Commit: 4890f1f75231aaf83e51c44342317fbad678b6c4
      https://github.com/openssl/openssl/commit/4890f1f75231aaf83e51c44342317fbad678b6c4
  Author: Matt Caswell <matt at openssl.org>
  Date:   2023-07-06 (Thu, 06 Jul 2023)

  Changed paths:
    M crypto/thread/build.info

  Log Message:
  -----------
  Fix no-thread-pool building

Reviewed-by: Tim Hudson <tjh at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21332)


  Commit: d001006e50e6ca591459f6b63d2365532578a36a
      https://github.com/openssl/openssl/commit/d001006e50e6ca591459f6b63d2365532578a36a
  Author: Matt Caswell <matt at openssl.org>
  Date:   2023-07-06 (Thu, 06 Jul 2023)

  Changed paths:
    M .github/workflows/cross-compiles.yml

  Log Message:
  -----------
  Work around relocation errors in the m68k cross-compilation builds

Errors such as this seen:

libssl.a(libssl-lib-ssl_stat.o): in function `SSL_alert_desc_string_long':
ssl_stat.c:(.text+0xab2): relocation truncated to fit: R_68K_GOT16O against `.LC157'
test/libtestutil.a(libtestutil-lib-opt.o): in function `opt_pair':
opt.c:(.text+0x10b2): relocation truncated to fit: R_68K_GOT16O against `.LC53'
test/libtestutil.a(libtestutil-lib-opt.o): in function `opt_string':
opt.c:(.text+0x113c): relocation truncated to fit: R_68K_GOT16O against `.LC53'
libcrypto.a(libcrypto-lib-decoder_lib.o): in function `OSSL_DECODER_CTX_set_construct_data':
decoder_lib.c:(.text+0x5a4): relocation truncated to fit: R_68K_GOT16O against `__func__.2'
libcrypto.a(libcrypto-lib-decoder_pkey.o): in function `ossl_decoder_ctx_setup_for_pkey':
decoder_pkey.c:(.text+0x6c2): relocation truncated to fit: R_68K_GOT16O against `decoder_construct_pkey'
libcrypto.a(libcrypto-lib-tb_dsa.o): in function `ENGINE_register_DSA':
tb_dsa.c:(.text+0x5e): relocation truncated to fit: R_68K_GOT16O against `dummy_nid'
libcrypto.a(libcrypto-lib-tb_dsa.o): in function `ENGINE_set_default_DSA':
tb_dsa.c:(.text+0xc4): relocation truncated to fit: R_68K_GOT16O against `dummy_nid'
libcrypto.a(libcrypto-lib-asymcipher.o): in function `.L18':
asymcipher.c:(.text+0x168): relocation truncated to fit: R_68K_GOT16O against `__func__.0'
asymcipher.c:(.text+0x2e8): relocation truncated to fit: R_68K_GOT16O against `__func__.0'
asymcipher.c:(.text+0x33e): relocation truncated to fit: R_68K_GOT16O against `__func__.0'
libcrypto.a(libcrypto-lib-digest.o): in function `EVP_MD_CTX_ctrl':
digest.c:(.text+0xa52): additional relocation overflows omitted from the output
collect2: error: ld returned 1 exit status

Reviewed-by: Tim Hudson <tjh at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21332)


  Commit: f9fcc7c727f0589fcd1f28ef09c8e10deee4f229
      https://github.com/openssl/openssl/commit/f9fcc7c727f0589fcd1f28ef09c8e10deee4f229
  Author: Matt Caswell <matt at openssl.org>
  Date:   2023-07-06 (Thu, 06 Jul 2023)

  Changed paths:
    M test/helpers/quictestlib.c
    M test/helpers/quictestlib.h
    M test/quicapitest.c
    M test/quicfaultstest.c

  Log Message:
  -----------
  Allow qtestlib to use a "fake_now" implementation

We then use it in test_corrupted_data() to remove an OSSL_sleep() which
may fail in some builds.

Reviewed-by: Tim Hudson <tjh at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21332)


Compare: https://github.com/openssl/openssl/compare/d88a0f5f3944...f9fcc7c727f0


More information about the openssl-commits mailing list