[openssl/openssl] 149c4f: Add a test for a retry during the handshake

Matt Caswell noreply at github.com
Sun Jul 16 23:42:09 UTC 2023


  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 149c4f98168ba19432986e82d30d15bd41bae475
      https://github.com/openssl/openssl/commit/149c4f98168ba19432986e82d30d15bd41bae475
  Author: Matt Caswell <matt at openssl.org>
  Date:   2023-07-17 (Mon, 17 Jul 2023)

  Changed paths:
    M test/helpers/ssltestlib.c
    M test/helpers/ssltestlib.h
    M test/sslapitest.c

  Log Message:
  -----------
  Add a test for a retry during the handshake

Test various scenarios for a write retry occuring during a handshake.

Reviewed-by: Dmitry Belyavskiy <beldmit at gmail.com>
Reviewed-by: Paul Dale <pauli at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21434)


  Commit: 404fb9965ed0dc7752d80f72c93358dfb45125c8
      https://github.com/openssl/openssl/commit/404fb9965ed0dc7752d80f72c93358dfb45125c8
  Author: Matt Caswell <matt at openssl.org>
  Date:   2023-07-17 (Mon, 17 Jul 2023)

  Changed paths:
    M ssl/statem/statem_lib.c

  Log Message:
  -----------
  Fix ssl3_do_write() to correctly handle retries

A BIO is documented to return -1 on write retry - but sometimes they return
0. ssl3_do_write() was incorrectly handling a 0 response.

Fixes #21422

Reviewed-by: Dmitry Belyavskiy <beldmit at gmail.com>
Reviewed-by: Paul Dale <pauli at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21434)


Compare: https://github.com/openssl/openssl/compare/33ef5fc2c2bf...404fb9965ed0


More information about the openssl-commits mailing list