[openssl/openssl] d6179e: Add a test for a retry during the handshake

Matt Caswell noreply at github.com
Sun Jul 16 23:45:10 UTC 2023


  Branch: refs/heads/openssl-3.1
  Home:   https://github.com/openssl/openssl
  Commit: d6179e6d35af663ca41de615f35a1200a35f85e8
      https://github.com/openssl/openssl/commit/d6179e6d35af663ca41de615f35a1200a35f85e8
  Author: Matt Caswell <matt at openssl.org>
  Date:   2023-07-17 (Mon, 17 Jul 2023)

  Changed paths:
    M test/helpers/ssltestlib.c
    M test/helpers/ssltestlib.h
    M test/sslapitest.c

  Log Message:
  -----------
  Add a test for a retry during the handshake

Test various scenarios for a write retry occuring during a handshake.

Reviewed-by: Dmitry Belyavskiy <beldmit at gmail.com>
Reviewed-by: Paul Dale <pauli at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21435)


  Commit: 034ea1d00e5816f35c3e4799d5c122e198e14b59
      https://github.com/openssl/openssl/commit/034ea1d00e5816f35c3e4799d5c122e198e14b59
  Author: Matt Caswell <matt at openssl.org>
  Date:   2023-07-17 (Mon, 17 Jul 2023)

  Changed paths:
    M ssl/statem/statem_lib.c

  Log Message:
  -----------
  Fix ssl3_do_write() to correctly handle retries

A BIO is documented to return -1 on write retry - but sometimes they return
0. ssl3_do_write() was incorrectly handling a 0 response.

Fixes #21422

Reviewed-by: Dmitry Belyavskiy <beldmit at gmail.com>
Reviewed-by: Paul Dale <pauli at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21435)


Compare: https://github.com/openssl/openssl/compare/46ba573c997d...034ea1d00e58


More information about the openssl-commits mailing list