[openssl/openssl] eec805: Make DH_check set some error bits in recently adde...

Bernd Edlinger noreply at github.com
Wed Jul 26 11:25:11 UTC 2023

  Branch: refs/heads/OpenSSL_1_1_1-stable
  Home:   https://github.com/openssl/openssl
  Commit: eec805ee71356c06f9a86192fa06507c3bb92b09
  Author: Bernd Edlinger <bernd.edlinger at hotmail.de>
  Date:   2023-07-26 (Wed, 26 Jul 2023)

  Changed paths:
    M crypto/dh/dh_check.c

  Log Message:
  Make DH_check set some error bits in recently added error

The pre-existing error cases where DH_check returned zero
are not related to the dh params in any way, but are only
triggered by out-of-memory errors, therefore having *ret
set to zero feels right, but since the new error case is
triggered by too large p values that is something different.
On the other hand some callers of this function might not
be prepared to handle the return value correctly but only
rely on *ret. Therefore we set some error bits in *ret as
additional safety measure.

Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21533)

More information about the openssl-commits mailing list