[openssl/openssl] a86817: bss_dgram.c: Use BIO_ADDR_sockaddr() and BIO_ADDR_...

[Richard Levitte]

  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: a8681703d48d062c2fc1736179218063275f8e33
      https://github.com/openssl/openssl/commit/a8681703d48d062c2fc1736179218063275f8e33
  Author: Richard Levitte <levitte at openssl.org>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M crypto/bio/bss_dgram.c

  Log Message:
  -----------
  bss_dgram.c: Use BIO_ADDR_sockaddr() and BIO_ADDR_sockaddr_size()

Especially, it's important to use BIO_ADDR_sockaddr_size() instead of
taking sizeof(addr), as BIO_ADDR is a union of several sockaddr variants
with different sizes, and some sendto() implementations are very picky
that the size is correct for the indicated sockaddr family.

Reviewed-by: Matt Caswell <matt at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/20449)


  Commit: 12c4e67675e691d7556a526aa062effff05a6532
      https://github.com/openssl/openssl/commit/12c4e67675e691d7556a526aa062effff05a6532
  Author: Richard Levitte <levitte at openssl.org>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M test/bio_dgram_test.c

  Log Message:
  -----------
  test//bio_dgram_test.c: Skip test when BIO_bind() fails

This test isn't supposed to test BIO_bind() itself, so we can be a bit
sloppy and assume that it fails because the attempted binding is not
supported on the platform where this is run.  For example, BIO_bind()
fails when it's given an IPv6 address and the platform where this is
run doesn't support that address family.

In a case like this, it's sensible enough to simply skip the test when
BIO_bind() fails.

Reviewed-by: Matt Caswell <matt at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/20449)


Compare: https://github.com/openssl/openssl/compare/ac57336cd258...12c4e67675e6