[openssl/openssl] 0fc00f: Do not fail if ctx dup does not succeed

Simo Sorce noreply at github.com
Tue Mar 14 21:45:26 UTC 2023


  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 0fc00fc0e3867fc5f95fab1046ad7d2a85db06f8
      https://github.com/openssl/openssl/commit/0fc00fc0e3867fc5f95fab1046ad7d2a85db06f8
  Author: Simo Sorce <simo at redhat.com>
  Date:   2023-03-15 (Wed, 15 Mar 2023)

  Changed paths:
    M crypto/evp/m_sigver.c
    M crypto/evp/p_sign.c
    M crypto/evp/p_verify.c
    M doc/man3/EVP_DigestSignInit.pod
    M doc/man3/EVP_DigestVerifyInit.pod
    M doc/man3/EVP_SignInit.pod
    M doc/man3/EVP_VerifyInit.pod

  Log Message:
  -----------
  Do not fail if ctx dup does not succeed

If the ctx was *really* needed we'll probably fail later with an error
anyway, so no point in failing immediately.

Document that this behavior is dependent on the provider used to
implement the signature/verification.

Signed-off-by: Simo Sorce <simo at redhat.com>

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Matt Caswell <matt at openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit at gmail.com>
(Merged from https://github.com/openssl/openssl/pull/20375)


  Commit: f3c0dd4f0cd3bc282575a98181f8190d81189a78
      https://github.com/openssl/openssl/commit/f3c0dd4f0cd3bc282575a98181f8190d81189a78
  Author: Simo Sorce <simo at redhat.com>
  Date:   2023-03-15 (Wed, 15 Mar 2023)

  Changed paths:
    M test/build.info
    M test/evp_extra_test.c
    M test/fake_rsaprov.c

  Log Message:
  -----------
  Add test for context duplication failure

This checks that the first operation successfully completes even if
context duplication fails. But follwing operations get errors as
if the context was finlised.

Signed-off-by: Simo Sorce <simo at redhat.com>

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Matt Caswell <matt at openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit at gmail.com>
(Merged from https://github.com/openssl/openssl/pull/20375)


  Commit: 3fc2b7d6b8f961144905330dfd4689f5bd515199
      https://github.com/openssl/openssl/commit/3fc2b7d6b8f961144905330dfd4689f5bd515199
  Author: Simo Sorce <simo at redhat.com>
  Date:   2023-03-15 (Wed, 15 Mar 2023)

  Changed paths:
    M crypto/evp/digest.c
    M crypto/evp/m_sigver.c
    M include/crypto/evp.h
    M include/openssl/evp.h

  Log Message:
  -----------
  Add a flag so finalised contexts are not reused

The EVP layer should not rely on the underlying low level code to
handle catching incorrect reuse of contexts.
Add a flag to mark a context as finalised as needed and then catch and
immediately error on Update/Final operations if called improperly.

Signed-off-by: Simo Sorce <simo at redhat.com>

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Matt Caswell <matt at openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit at gmail.com>
(Merged from https://github.com/openssl/openssl/pull/20375)


Compare: https://github.com/openssl/openssl/compare/dba97d4c7142...3fc2b7d6b8f9


More information about the openssl-commits mailing list