[openssl/openssl] c1f13e: Handle app data records from the next epoch

Matt Caswell noreply at github.com
Fri Mar 31 08:39:49 UTC 2023


  Branch: refs/heads/openssl-3.0
  Home:   https://github.com/openssl/openssl
  Commit: c1f13e1d640602cf85ec1e7bd3605ae2cc4b8334
      https://github.com/openssl/openssl/commit/c1f13e1d640602cf85ec1e7bd3605ae2cc4b8334
  Author: Matt Caswell <matt at openssl.org>
  Date:   2023-03-31 (Fri, 31 Mar 2023)

  Changed paths:
    M ssl/record/rec_layer_d1.c

  Log Message:
  -----------
  Handle app data records from the next epoch

It is possible that DTLS records are received out of order such that
records from the next epoch arrive before we have finished processing the
current epoch. We are supposed to buffer such records but for some reason
we only did that for handshake and alert records. This is incorrect since
it is perfectly possible for app data records to arrive early too.

Fixes #20597

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/20638)


  Commit: a46a786cd367b4373d60dd6eec928e757df34b81
      https://github.com/openssl/openssl/commit/a46a786cd367b4373d60dd6eec928e757df34b81
  Author: Matt Caswell <matt at openssl.org>
  Date:   2023-03-31 (Fri, 31 Mar 2023)

  Changed paths:
    M test/dtlstest.c
    M test/helpers/ssltestlib.c
    M test/helpers/ssltestlib.h

  Log Message:
  -----------
  Add a test for an app data record appearing before epoch change in DTLS

We had a test for a handshake record appearing before epoch change, and
a test for an app data record appearing before Finished - but not one for
the app data record appearing before epoch change.

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/20638)


Compare: https://github.com/openssl/openssl/compare/51e8a84ce742...a46a786cd367


More information about the openssl-commits mailing list