[openssl/openssl] 636619: QUIC MULTISTREAM TEST: Fix script 38 stochastic fa...

[Hugo Landau]

  Branch: refs/heads/openssl-3.2
  Home:   https://github.com/openssl/openssl
  Commit: 6366192d56d22f44992aa891634085865b12d418
      https://github.com/openssl/openssl/commit/6366192d56d22f44992aa891634085865b12d418
  Author: Hugo Landau <hlandau at openssl.org>
  Date:   2023-11-02 (Thu, 02 Nov 2023)

  Changed paths:
    M test/quic_multistream_test.c

  Log Message:
  -----------
  QUIC MULTISTREAM TEST: Fix script 38 stochastic failure on Windows

The QUIC fault injector frame injection functionality injects injected
frames on whatever EL we happen to be using to generate a packet in.
This means we sometimes inject the frame into a packet type it is not
allowed to be in, causing a different error code to be generated.

Fix this by making sure the connection is fully established before
trying to generate the frame in question.

Fixes #22348.

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Matt Caswell <matt at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/22578)

(cherry picked from commit a6eb287a667ccbc241c59b23b151672e450bda4b)


  Commit: 6aa921f27bba5c55acd4ea83d4f221b6c876c59d
      https://github.com/openssl/openssl/commit/6aa921f27bba5c55acd4ea83d4f221b6c876c59d
  Author: Hugo Landau <hlandau at openssl.org>
  Date:   2023-11-02 (Thu, 02 Nov 2023)

  Changed paths:
    M test/quic_multistream_test.c

  Log Message:
  -----------
  QUIC MULTISTREAM TEST: Ensure frames are only injected into correct packet types

Although the previous commit is enough to fix the immediate cause of the
stochastic failure on Windows, this is a more resilient fix; make sure
we only inject a given frame into the correct packet type for our
various injection functions.

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Matt Caswell <matt at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/22578)

(cherry picked from commit 660718ee5bafce9c5ca7604801a59f53df28f202)


Compare: https://github.com/openssl/openssl/compare/4febab7d808c...6aa921f27bba