[openssl/openssl] dec12f: Coverity 1545176: dereference before NULL check

Pauli noreply at github.com
Tue Oct 3 08:05:31 UTC 2023


  Branch: refs/heads/openssl-3.1
  Home:   https://github.com/openssl/openssl
  Commit: dec12f23481036b492c7ca8d5590eb52cc35dab0
      https://github.com/openssl/openssl/commit/dec12f23481036b492c7ca8d5590eb52cc35dab0
  Author: Pauli <pauli at openssl.org>
  Date:   2023-10-03 (Tue, 03 Oct 2023)

  Changed paths:
    M crypto/rand/rand_lib.c

  Log Message:
  -----------
  Coverity 1545176: dereference before NULL check

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove at arm.com>
(Merged from https://github.com/openssl/openssl/pull/22211)

(cherry picked from commit 15410839c668f97b5c03ee1a1bc1a2bf4315715f)


  Commit: d9395ec8897b8768265bf3fcbdd877a6c4cdcbc6
      https://github.com/openssl/openssl/commit/d9395ec8897b8768265bf3fcbdd877a6c4cdcbc6
  Author: Pauli <pauli at openssl.org>
  Date:   2023-10-03 (Tue, 03 Oct 2023)

  Changed paths:
    M providers/implementations/rands/test_rng.c

  Log Message:
  -----------
  Coverity 1545174: calling risky function

Remove the call to rand() and replace with an xor-shift RNG.
There are no security implications to worry about here.  This RNG is
used during testing only.

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove at arm.com>
(Merged from https://github.com/openssl/openssl/pull/22211)

(cherry picked from commit eaf08794398ac3caaadffcfd670854bf51f610fa)


  Commit: eda5e112b1d52cec545c8a699295afaafda0209a
      https://github.com/openssl/openssl/commit/eda5e112b1d52cec545c8a699295afaafda0209a
  Author: Pauli <pauli at openssl.org>
  Date:   2023-10-03 (Tue, 03 Oct 2023)

  Changed paths:
    M crypto/rand/rand_lib.c

  Log Message:
  -----------
  Coverity 1545175: use after free

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove at arm.com>
(Merged from https://github.com/openssl/openssl/pull/22211)

(cherry picked from commit 6bd07949e54f9958eb8a0f9a597ceb3910753ab0)


Compare: https://github.com/openssl/openssl/compare/e07093f222e2...eda5e112b1d5


More information about the openssl-commits mailing list