[openssl/openssl] b49caf: test: evp_extra: fix indentation error

Matthias St. Pierre noreply at github.com
Wed Oct 4 10:24:41 UTC 2023


  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: b49cafd86b295aa5e177d6c1368b06a1202ec2b3
      https://github.com/openssl/openssl/commit/b49cafd86b295aa5e177d6c1368b06a1202ec2b3
  Author: Matthias St. Pierre <matthias.st.pierre at ncp-e.com>
  Date:   2023-10-04 (Wed, 04 Oct 2023)

  Changed paths:
    M test/evp_extra_test.c

  Log Message:
  -----------
  test: evp_extra: fix indentation error

Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/22185)


  Commit: 860e36d0dd72f4aa4791e88aa185cb42065a30c4
      https://github.com/openssl/openssl/commit/860e36d0dd72f4aa4791e88aa185cb42065a30c4
  Author: Matthias St. Pierre <matthias.st.pierre at ncp-e.com>
  Date:   2023-10-04 (Wed, 04 Oct 2023)

  Changed paths:
    M test/evp_extra_test.c

  Log Message:
  -----------
  test: evp_extra: test signing with legacy app method based keys

This commit adds `test_EVP_PKEY_sign_with_app_method`, a regression
test for the bug fix in commit 1acc3e8cc3c6 (pull request #22163).

It is analogous to `test_EVP_PKEY_sign`, only with a fake app method
based key. (The EC key test case was omitted, because there is no
`EC_KEY_METHOD_dup` method.)

Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/22185)


  Commit: 706512ecbc31585d447b53c3aa89acdf6951f996
      https://github.com/openssl/openssl/commit/706512ecbc31585d447b53c3aa89acdf6951f996
  Author: Matthias St. Pierre <matthias.st.pierre at ncp-e.com>
  Date:   2023-10-04 (Wed, 04 Oct 2023)

  Changed paths:
    M crypto/dh/dh_key.c
    M crypto/dh/dh_lib.c
    M crypto/dsa/dsa_lib.c
    M crypto/dsa/dsa_ossl.c

  Log Message:
  -----------
  Don't (re-)initialize the FFC_PARAMs in dh_init and dsa_init

The initialization was introduced in commit dc8de3e6f1ee and
changes the behaviour of the `init` method for DSA and DH
between 1.1.1 and 3.0, while the behaviour for RSA and EC_KEY
remains unchanged.

The initialization is not necessary in 3.x and master imho and
breaks the use-case of intercepting the methods of an existing
key.

Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/22185)


Compare: https://github.com/openssl/openssl/compare/82496b8663f2...706512ecbc31


More information about the openssl-commits mailing list