[openssl/openssl] 2e62b0: Don't wait in the tesrver idle testing every time ...

Matt Caswell noreply at github.com
Fri Oct 6 09:59:40 UTC 2023


  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 2e62b07a41cca299f7abb69c892053b99ec762b2
      https://github.com/openssl/openssl/commit/2e62b07a41cca299f7abb69c892053b99ec762b2
  Author: Matt Caswell <matt at openssl.org>
  Date:   2023-10-06 (Fri, 06 Oct 2023)

  Changed paths:
    M test/quic_tserver_test.c

  Log Message:
  -----------
  Don't wait in the tesrver idle testing every time around the loop

If we wait for 100ms 600 times - then the test takes a minute to complete
which is far too long. The purpose of the wait is to give the assistance
thread a chance to catch up. We only do that if the event timeout has
actually expired - otherwise we are waiting for no reason.

Fixes #22156

Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: Richard Levitte <levitte at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/22284)


  Commit: 79997a919f6cf3823d04fa9b34adaaa5aadd871a
      https://github.com/openssl/openssl/commit/79997a919f6cf3823d04fa9b34adaaa5aadd871a
  Author: Matt Caswell <matt at openssl.org>
  Date:   2023-10-06 (Fri, 06 Oct 2023)

  Changed paths:
    M test/quic_tserver_test.c

  Log Message:
  -----------
  Timeout in the tserver test using real time

When running the tserver test we bail out if a timeout expires. We
shouldn't use fake time for that timeout, because fake time might never
actually get incremented.

Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: Richard Levitte <levitte at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/22284)


Compare: https://github.com/openssl/openssl/compare/4ace824852f3...79997a919f6c


More information about the openssl-commits mailing list