[openssl/openssl] 715242: test/recipes/05-test_rand.t: replace 'and' with '&&'

Richard Levitte noreply at github.com
Wed Oct 11 12:20:33 UTC 2023


  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 715242b1ca2b7267a70fb13c3544a84b947a6e81
      https://github.com/openssl/openssl/commit/715242b1ca2b7267a70fb13c3544a84b947a6e81
  Author: Richard Levitte <levitte at openssl.org>
  Date:   2023-10-11 (Wed, 11 Oct 2023)

  Changed paths:
    M test/recipes/05-test_rand.t

  Log Message:
  -----------
  test/recipes/05-test_rand.t: replace 'and' with '&&'

The lower priority 'and' seems to have some "interesting" interactions with
function argument parsing in some perl versions (presumably because 'and' is
lower priority than the comma).

For the lines that are changed here, perl v5.20.1 says this:

    Useless use of string eq in void context at [.test.recipes]05-test_rand.t line 33.
    Useless use of numeric eq (==) in void context at [.test.recipes]05-test_rand.t line 39.

Replacing 'and' with '&&' in these two cases fixes the problem.

Replacing

Reviewed-by: Hugo Landau <hlandau at openssl.org>
Reviewed-by: Matt Caswell <matt at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/22331)




More information about the openssl-commits mailing list