[openssl/openssl] 100198: ossl_param_build_set_multi_key_bn(): Do not set NU...

[Neil Horman]

  Branch: refs/heads/openssl-3.0
  Home:   https://github.com/openssl/openssl
  Commit: 100198fe715d47dcbcf5681596d361beb6740b51
      https://github.com/openssl/openssl/commit/100198fe715d47dcbcf5681596d361beb6740b51
  Author: Tomas Mraz <tomas at openssl.org>
  Date:   2023-10-18 (Wed, 18 Oct 2023)

  Changed paths:
    M crypto/param_build_set.c

  Log Message:
  -----------
  ossl_param_build_set_multi_key_bn(): Do not set NULL BIGNUMs

This makes them zeroes otherwise
where NULLs actually mean the values aren't present.

Fixes #21935

Reviewed-by: Richard Levitte <levitte at openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove at arm.com>
(Merged from https://github.com/openssl/openssl/pull/22334)

(cherry picked from commit 15a39e7025e0ed4e31664c499894006e41582068)


  Commit: cdfc6d4fa837191533ae0f6d2b420a75ee55df7e
      https://github.com/openssl/openssl/commit/cdfc6d4fa837191533ae0f6d2b420a75ee55df7e
  Author: Neil Horman <nhorman at openssl.org>
  Date:   2023-10-18 (Wed, 18 Oct 2023)

  Changed paths:
    M crypto/rsa/rsa_backend.c

  Log Message:
  -----------
  remove sanity check from ossl_rsa_todata

Theres no reason we should gate ossl_rsa_todata on there being a minimum
set of parameters. EVP_PKEY_todata makes no guarantees about the
validity of a key, it only returns the parameters that are set in the
requested key, whatever they may be.  Remove the check.

Fixes #21935

Reviewed-by: Richard Levitte <levitte at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/22334)

(cherry picked from commit 4ad3a44ba45a4026170336161228d435f6784564)


  Commit: cfd5b0509ddaf2103a07ae9cc90d0750e4b5d852
      https://github.com/openssl/openssl/commit/cfd5b0509ddaf2103a07ae9cc90d0750e4b5d852
  Author: Neil Horman <nhorman at openssl.org>
  Date:   2023-10-18 (Wed, 18 Oct 2023)

  Changed paths:
    M crypto/rsa/rsa_lib.c

  Log Message:
  -----------
  Dont require CRT params on ossl_rsa_set0_all_params

Its not required that crt params be available in an RSA key, so don't
perform an error check on them

Fixes #29135

Reviewed-by: Richard Levitte <levitte at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/22334)

(cherry picked from commit 2647726bd3ca63dc5f07ae3f10e16dff35d95626)


  Commit: 4a1c530e1f6d38ae7bf12db9f99e19bf8f0f082b
      https://github.com/openssl/openssl/commit/4a1c530e1f6d38ae7bf12db9f99e19bf8f0f082b
  Author: Neil Horman <nhorman at openssl.org>
  Date:   2023-10-18 (Wed, 18 Oct 2023)

  Changed paths:
    M test/rsa_test.c

  Log Message:
  -----------
  Add a test to confirm that legacy rsa keys work

Reviewed-by: Richard Levitte <levitte at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/22334)

(cherry picked from commit e62097f48c3d0b8b61ca6a061b8098b0086b3fbc)


Compare: https://github.com/openssl/openssl/compare/33e18be32e62...4a1c530e1f6d