[openssl/openssl] 80f329: Do not include crypto/asn1.h from internal/cryptlib.h

Tomáš Mráz noreply at github.com
Thu Oct 19 08:18:19 UTC 2023


  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 80f32964a5388f5a313ced88f17a41f17794e369
      https://github.com/openssl/openssl/commit/80f32964a5388f5a313ced88f17a41f17794e369
  Author: Tomas Mraz <tomas at openssl.org>
  Date:   2023-10-19 (Thu, 19 Oct 2023)

  Changed paths:
    M crypto/asn1/asn1_gen.c
    M crypto/x509/v3_addr.c
    M include/internal/cryptlib.h

  Log Message:
  -----------
  Do not include crypto/asn1.h from internal/cryptlib.h

This is unnecessary and conceptualy wrong as
headers from internal should not include headers from crypto

Reviewed-by: Hugo Landau <hlandau at openssl.org>
Reviewed-by: Matt Caswell <matt at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/22432)


  Commit: fa9e6ad46860ea92aa2e1ba997b20c6dff76b42c
      https://github.com/openssl/openssl/commit/fa9e6ad46860ea92aa2e1ba997b20c6dff76b42c
  Author: Tomas Mraz <tomas at openssl.org>
  Date:   2023-10-19 (Thu, 19 Oct 2023)

  Changed paths:
    M crypto/cms/cms_enc.c

  Log Message:
  -----------
  cms_enc.c: Include crypto/asn1.h for struct asn1_object_st

Reviewed-by: Hugo Landau <hlandau at openssl.org>
Reviewed-by: Matt Caswell <matt at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/22432)


Compare: https://github.com/openssl/openssl/compare/1d768852e938...fa9e6ad46860


More information about the openssl-commits mailing list