[openssl/openssl] 86e11b: When requeueing deferred URXEs retain the order

Matt Caswell noreply at github.com
Tue Oct 24 16:39:20 UTC 2023


  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 86e11b1e78ad6937ef32d64ca34013306c9abc28
      https://github.com/openssl/openssl/commit/86e11b1e78ad6937ef32d64ca34013306c9abc28
  Author: Matt Caswell <matt at openssl.org>
  Date:   2023-10-24 (Tue, 24 Oct 2023)

  Changed paths:
    M ssl/quic/quic_record_rx.c
    M test/recipes/75-test_quicapi_data/ssltraceref-zlib.txt
    M test/recipes/75-test_quicapi_data/ssltraceref.txt

  Log Message:
  -----------
  When requeueing deferred URXEs retain the order

If a URXE cannot be processed yet then we add it to the urx_deferred list.
Later, when they can be processed, we requeue them in the urx_pending list.

We must not reverse the order when doing so. We want to process the URXEs
in the order that they were received.

Reviewed-by: Hugo Landau <hlandau at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: Todd Short <todd.short at me.com>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/22452)


  Commit: b9b9f4886f87abd39535721243d4297fd45e558a
      https://github.com/openssl/openssl/commit/b9b9f4886f87abd39535721243d4297fd45e558a
  Author: Matt Caswell <matt at openssl.org>
  Date:   2023-10-24 (Tue, 24 Oct 2023)

  Changed paths:
    M ssl/record/rec_layer_s3.c

  Log Message:
  -----------
  Make sure we remember how much data we sent in the event of a retry

If a retry occurs we need to reset s->rlayer.wnum so that next time around
we remember how much data we already sent.

Reviewed-by: Hugo Landau <hlandau at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/22473)


  Commit: dbbdb940d421daca4a65e765b5244bde6aed3f61
      https://github.com/openssl/openssl/commit/dbbdb940d421daca4a65e765b5244bde6aed3f61
  Author: Matt Caswell <matt at openssl.org>
  Date:   2023-10-24 (Tue, 24 Oct 2023)

  Changed paths:
    M test/helpers/ssltestlib.c
    M test/helpers/ssltestlib.h
    M test/sslapitest.c

  Log Message:
  -----------
  Add a test for retries when sending app data

Reviewed-by: Hugo Landau <hlandau at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/22473)


Compare: https://github.com/openssl/openssl/compare/acf95129bce6...dbbdb940d421


More information about the openssl-commits mailing list