[openssl/openssl] 670e73: ecc: Remove extraneous parentheses in secp384r1

[Matt Caswell]

  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 670e73d9084465384b11ef24802ca4a313e1d2f4
      https://github.com/openssl/openssl/commit/670e73d9084465384b11ef24802ca4a313e1d2f4
  Author: Rohan McLure <rohanmclure at linux.ibm.com>
  Date:   2023-09-01 (Fri, 01 Sep 2023)

  Changed paths:
    M crypto/ec/ecp_nistp384.c

  Log Message:
  -----------
  ecc: Remove extraneous parentheses in secp384r1

Substitutions in the felem_reduce() method feature unecessary
parentheses, remove them.

Signed-off-by: Rohan McLure <rohan.mclure at linux.ibm.com>

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Shane Lontis <shane.lontis at oracle.com>
Reviewed-by: Hugo Landau <hlandau at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21749)


  Commit: 50f8b936b00dc18ce1f622a7a6aa46daf03da48b
      https://github.com/openssl/openssl/commit/50f8b936b00dc18ce1f622a7a6aa46daf03da48b
  Author: Rohan McLure <rohanmclure at linux.ibm.com>
  Date:   2023-09-01 (Fri, 01 Sep 2023)

  Changed paths:
    M crypto/ec/asm/ecp_nistp384-ppc64.pl

  Log Message:
  -----------
  powerpc: ecc: Fix stack allocation secp384r1 asm

Assembly acceleration secp384r1 opts to not use any callee-save VSRs, as
VSX enabled systems make extensive use of renaming, and so writebacks in
felem_{mul,square}() can be reordered for best cache effects.

Remove stack allocations. This in turn fixes unmatched push/pops in
felem_{mul,square}().

Signed-off-by: Rohan McLure <rohan.mclure at linux.ibm.com>

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Shane Lontis <shane.lontis at oracle.com>
Reviewed-by: Hugo Landau <hlandau at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21749)


  Commit: 3961991593f788b3efb2a27563d358c7c58f854c
      https://github.com/openssl/openssl/commit/3961991593f788b3efb2a27563d358c7c58f854c
  Author: Matt Caswell <matt at openssl.org>
  Date:   2023-09-01 (Fri, 01 Sep 2023)

  Changed paths:
    M crypto/ec/ec_key.c

  Log Message:
  -----------
  Remove a redundant point mul from ossl_ec_key_public_check()

This code was added in error and is entirely redundant. It is also an
expensive operation (e.g. see #21833).

Fixes #21834

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: Shane Lontis <shane.lontis at oracle.com>
Reviewed-by: Hugo Landau <hlandau at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21902)


Compare: https://github.com/openssl/openssl/compare/60421893a286...3961991593f7