[openssl/openssl] b0da24: BIO_set_accept_name(): To accept from any interfac...

Richard Levitte noreply at github.com
Fri Sep 8 06:31:15 UTC 2023


  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: b0da24bd2dc64e3a01df24e01aba37fe4c269230
      https://github.com/openssl/openssl/commit/b0da24bd2dc64e3a01df24e01aba37fe4c269230
  Author: Richard Levitte <levitte at openssl.org>
  Date:   2023-09-08 (Fri, 08 Sep 2023)

  Changed paths:
    M apps/lib/http_server.c

  Log Message:
  -----------
  BIO_set_accept_name(): To accept from any interface, use *

Using "*:{port}" is preferred to "[::]:{port}", because it won't break on
IPv4-only machines.

This fixes test failures in 79-test_http.t and 80-test_ssl_new.t on machines
without IPv6.

Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21989)


  Commit: 769e47ecddd1ca4292ffa792f45998629447d743
      https://github.com/openssl/openssl/commit/769e47ecddd1ca4292ffa792f45998629447d743
  Author: Richard Levitte <levitte at openssl.org>
  Date:   2023-09-08 (Fri, 08 Sep 2023)

  Changed paths:
    M test/recipes/80-test_cmp_http.t
    M test/recipes/80-test_cmp_http_data/test_connection.csv

  Log Message:
  -----------
  Fix 80-test_cmp_http.t to be more flexible regarding IP versions

Because apps/lib/http_server.c had a hard coded "[::]" for the accept host,
80-test_cmp_http.t assumed that it would always get a CMP server on an IPv6
address, and tested for that.

With the fix in apps/lib/http_server.c, that test was of course doomed to
fail.  Since CMP should be about IP version testing, 80-test_cmp_http.t is
adapted to allow the Mock server to accept connections on either IP version,
and the test for IPv6 is removed.

Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21989)


Compare: https://github.com/openssl/openssl/compare/b9a189ce87fd...769e47ecddd1


More information about the openssl-commits mailing list