[openssl/openssl] 0d5d03: OSSL_STORE: Fix error flag clearing and setting (p...

[Richard Levitte]

  Branch: refs/heads/openssl-3.1
  Home:   https://github.com/openssl/openssl
  Commit: 0d5d03787a6d0c836426e09f6ab7604547fd585f
      https://github.com/openssl/openssl/commit/0d5d03787a6d0c836426e09f6ab7604547fd585f
  Author: Richard Levitte <levitte at openssl.org>
  Date:   2023-09-08 (Fri, 08 Sep 2023)

  Changed paths:
    M crypto/store/store_lib.c

  Log Message:
  -----------
  OSSL_STORE: Fix error flag clearing and setting (provider path only)

When the provider's load function returned with an error, the libcrypto
error flag was only set if EOF hadn't been reached.  This is troublesome,
as an error can very well occur during the last load before EOF is reached!

Also, the error flag was never reset, even though documentation specifies
that it should indicate an error in the last load (i.e. not the one before
that).

Fixes #21968

Reviewed-by: Dmitry Belyavskiy <beldmit at gmail.com>
Reviewed-by: Paul Dale <pauli at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21976)

(cherry picked from commit 17dd9a2c6262c00800301fddd9441a9c590a630e)