[openssl/openssl] d739b3: make inability to dup/clone ciphers an error

Neil Horman noreply at github.com
Tue Sep 12 14:04:17 UTC 2023


  Branch: refs/heads/openssl-3.1
  Home:   https://github.com/openssl/openssl
  Commit: d739b3e05e749d4310b7310c007a4f3b8d5f8556
      https://github.com/openssl/openssl/commit/d739b3e05e749d4310b7310c007a4f3b8d5f8556
  Author: Neil Horman <nhorman at openssl.org>
  Date:   2023-09-12 (Tue, 12 Sep 2023)

  Changed paths:
    M test/evp_test.c

  Log Message:
  -----------
  make inability to dup/clone ciphers an error

There should be no reason that a cipher can't be duplicated

Fixes #21887

Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21933)

(cherry picked from commit 39d857bb610d25b3de4e414264246ec41753c446)


  Commit: a982016c56f8c631e0906b0a33f4feaf3d20a2ff
      https://github.com/openssl/openssl/commit/a982016c56f8c631e0906b0a33f4feaf3d20a2ff
  Author: Neil Horman <nhorman at openssl.org>
  Date:   2023-09-12 (Tue, 12 Sep 2023)

  Changed paths:
    M providers/implementations/ciphers/cipher_aes_ccm.c
    M providers/implementations/ciphers/cipher_aes_gcm.c
    M providers/implementations/ciphers/cipher_aria_ccm.c
    M providers/implementations/ciphers/cipher_aria_gcm.c
    M providers/implementations/ciphers/cipher_sm4_ccm.c
    M providers/implementations/ciphers/cipher_sm4_gcm.c
    M providers/implementations/include/prov/ciphercommon_aead.h

  Log Message:
  -----------
  Add dupctx support to aead ciphers

Add dupctx method support to to ciphers implemented with IMPLEMENT_aead_cipher
This includes:
aes-<kbits>-gcm
aria-<kbits>-ccm
aria-<kbits>-gcm
sm4-<kibs>-gcm

Fixes #21887

Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21933)

(cherry picked from commit 0239fb3db77e9de2031c5054854cba8e417c1b72)


  Commit: 819ae76bb76540a4321e548851e23099ddf71e8e
      https://github.com/openssl/openssl/commit/819ae76bb76540a4321e548851e23099ddf71e8e
  Author: Neil Horman <nhorman at openssl.org>
  Date:   2023-09-12 (Tue, 12 Sep 2023)

  Changed paths:
    M providers/implementations/ciphers/cipher_aes_wrp.c

  Log Message:
  -----------
  implement dupctx for aes_WRAP methods

create a dupctx method for aes_WRAP implementations of all sizes

Fixes #21887

Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21933)

(cherry picked from commit 2c021e7d11f03ede2330398c4fd8e8c7bd8768ee)


  Commit: 603b4c332f817cfc14a0d8b30d1e5a198f575644
      https://github.com/openssl/openssl/commit/603b4c332f817cfc14a0d8b30d1e5a198f575644
  Author: Neil Horman <nhorman at openssl.org>
  Date:   2023-09-12 (Tue, 12 Sep 2023)

  Changed paths:
    M providers/implementations/ciphers/cipher_chacha20_poly1305.c

  Log Message:
  -----------
  implement dupctx for chacha20_poly1305

Same as chacha20 in the last commit, just clone the ctx and its
underlying tlsmac array if its allocated

Fixes #21887

Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21933)

(cherry picked from commit df93b3c9e72571876bd01e5a50a5ba8368c6c77f)


  Commit: d9f84aef6033804e4c7ebf28ee88fcd2c63161d6
      https://github.com/openssl/openssl/commit/d9f84aef6033804e4c7ebf28ee88fcd2c63161d6
  Author: Neil Horman <nhorman at openssl.org>
  Date:   2023-09-12 (Tue, 12 Sep 2023)

  Changed paths:
    M providers/implementations/ciphers/cipher_aes_cbc_hmac_sha.c
    M providers/implementations/ciphers/cipher_rc4_hmac_md5.c

  Log Message:
  -----------
  Add dupctx support to rc4_hmac_md5 algo

Pretty straightforward, just clone the requested context, no pointers to
fixup

Fixes #21887

Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21933)

(cherry picked from commit 123c85864fa7fe97d8ae3a09989d410501d957a5)


Compare: https://github.com/openssl/openssl/compare/838173b61493...d9f84aef6033


More information about the openssl-commits mailing list