[openssl/openssl] 0058a5: Revert "Improved detection of engine-provided priv...

[Tomáš Mráz]

  Branch: refs/heads/openssl-3.1
  Home:   https://github.com/openssl/openssl
  Commit: 0058a55407d824d5b55ecc0a1cbf8931803dc238
      https://github.com/openssl/openssl/commit/0058a55407d824d5b55ecc0a1cbf8931803dc238
  Author: Tomas Mraz <tomas at openssl.org>
  Date:   2024-01-31 (Wed, 31 Jan 2024)

  Changed paths:
    M crypto/engine/eng_pkey.c

  Log Message:
  -----------
  Revert "Improved detection of engine-provided private "classic" keys"

This reverts commit 2b74e75331a27fc89cad9c8ea6a26c70019300b5.

The commit was wrong. With 3.x versions the engines must be themselves
responsible for creating their EVP_PKEYs in a way that they are treated
as legacy - either by using the respective set1 calls or by setting
non-default EVP_PKEY_METHOD.

The workaround has caused more problems than it solved.

Fixes #22945

Reviewed-by: Dmitry Belyavskiy <beldmit at gmail.com>
Reviewed-by: Neil Horman <nhorman at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/23063)

(cherry picked from commit 39ea78379826fa98e8dc8c0d2b07e2c17cd68380)


  Commit: f8462a352dfaa2cdce933dd2be48bf39ae91b381
      https://github.com/openssl/openssl/commit/f8462a352dfaa2cdce933dd2be48bf39ae91b381
  Author: Tomas Mraz <tomas at openssl.org>
  Date:   2024-01-31 (Wed, 31 Jan 2024)

  Changed paths:
    M doc/man7/migration_guide.pod

  Log Message:
  -----------
  Document the implications of setting engine-based low-level methods

Reviewed-by: Dmitry Belyavskiy <beldmit at gmail.com>
Reviewed-by: Neil Horman <nhorman at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/23063)

(cherry picked from commit dbb478a51d3f695ec713e9829a2353a0d2d61a59)


Compare: https://github.com/openssl/openssl/compare/8d60a4f1da13...f8462a352dfa