[openssl/openssl] 2b5a5c: QUIC qlog: Enable qlog in Windows CI

Hugo Landau noreply at github.com
Fri Feb 9 11:06:56 UTC 2024


  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 2b5a5c87df23ee5b0344197174bf1219b04d2ebe
      https://github.com/openssl/openssl/commit/2b5a5c87df23ee5b0344197174bf1219b04d2ebe
  Author: Hugo Landau <hlandau at openssl.org>
  Date:   2024-02-09 (Fri, 09 Feb 2024)

  Changed paths:
    M .github/workflows/os-zoo.yml
    M .github/workflows/windows.yml

  Log Message:
  -----------
  QUIC qlog: Enable qlog in Windows CI

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove at arm.com>
Reviewed-by: Neil Horman <nhorman at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/23517)


  Commit: 1260d0f5792b5253ecd8ca23eee848ab2c50c1ea
      https://github.com/openssl/openssl/commit/1260d0f5792b5253ecd8ca23eee848ab2c50c1ea
  Author: Hugo Landau <hlandau at openssl.org>
  Date:   2024-02-09 (Fri, 09 Feb 2024)

  Changed paths:
    M test/json_test.c

  Log Message:
  -----------
  JSON_ENC: Fix unit test for MSVC

Previously scripts were defined like this:

    {
        static const char *const script_name = "xxx";

        static const struct script_info script_info = {
            script_name, ...
        };

        return &script_info;
    }

MSVC cannot handle this, presumably because this technically involves a
load from a variable to determine that script_name equals "xxx" and it
is unable to do this during evaluation of a constant initializer list.
Resolve this by changing script_name and script_title to be arrays
instead, allowing the correct pointer values to be filled into
script_info as symbol addresses/relocations rather than dereferences.

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove at arm.com>
Reviewed-by: Neil Horman <nhorman at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/23517)


  Commit: 1548e3cdaa3d478bdfbb214855a537be184db89f
      https://github.com/openssl/openssl/commit/1548e3cdaa3d478bdfbb214855a537be184db89f
  Author: Hugo Landau <hlandau at openssl.org>
  Date:   2024-02-09 (Fri, 09 Feb 2024)

  Changed paths:
    M ssl/quic/qlog.c

  Log Message:
  -----------
  QUIC QLOG: Retrieve PID correctly on Windows

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove at arm.com>
Reviewed-by: Neil Horman <nhorman at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/23517)


  Commit: 2c63ec6fd3ade0c37a68ed2d2054477d86155922
      https://github.com/openssl/openssl/commit/2c63ec6fd3ade0c37a68ed2d2054477d86155922
  Author: Hugo Landau <hlandau at openssl.org>
  Date:   2024-02-09 (Fri, 09 Feb 2024)

  Changed paths:
    M ssl/quic/qlog_event_helpers.c

  Log Message:
  -----------
  QUIC QLOG: Fix use of size_t and uint64_t

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove at arm.com>
Reviewed-by: Neil Horman <nhorman at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/23517)


  Commit: bdba075c1962b7c69b6f40ebef9e0bf1f1325dd8
      https://github.com/openssl/openssl/commit/bdba075c1962b7c69b6f40ebef9e0bf1f1325dd8
  Author: Hugo Landau <hlandau at openssl.org>
  Date:   2024-02-09 (Fri, 09 Feb 2024)

  Changed paths:
    M util/platform_symbols/windows-symbols.txt

  Log Message:
  -----------
  Windows: Add _dclass to the allowed symbols list

We use isnan() and isinf() in JSON_ENC now, which is translated to a
call to Microsoft's standard library function _dclass.

.

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove at arm.com>
Reviewed-by: Neil Horman <nhorman at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/23517)


Compare: https://github.com/openssl/openssl/compare/cb4f7a6ee053...bdba075c1962


More information about the openssl-commits mailing list