[openssl/openssl] 6f811d: Replace and Deprecate TS_VERIFY_CTX Functions

Tobias Erbsland noreply at github.com
Wed Jul 10 07:42:58 UTC 2024


  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 6f811d839fd637fa5dea0ee4286722847ab74b98
      https://github.com/openssl/openssl/commit/6f811d839fd637fa5dea0ee4286722847ab74b98
  Author: erbsland-dev <github at erbsland.dev>
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
    M apps/ts.c
    M crypto/ts/ts_verify_ctx.c
    M include/openssl/ts.h

  Log Message:
  -----------
  Replace and Deprecate TS_VERIFY_CTX Functions

Fixes #18854

Replace and deprecate the functions `TS_VERIFY_CTX_set_data`,
`TS_VERIFY_CTX_set_store`, `TS_VERIFY_CTX_set_certs`, `TS_VERIFY_CTX_set_imprint`
with new versions: `TS_VERIFY_CTX_set0_data`,
`TS_VERIFY_CTX_set0_store`, `TS_VERIFY_CTX_set0_certs` and `TS_VERIFY_CTX_set0_imprint`.

The previous functions had poorly documented memory handling, potentially
leading to memory leaks. The new functions improve memory management and provide
clearer usage.

Also, update existing code to use the new function calls instead of the deprecated
ones.

Reviewed-by: Neil Horman <nhorman at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/24701)


  Commit: 2c1ef172f83d78490be553982a5f08503d4b4590
      https://github.com/openssl/openssl/commit/2c1ef172f83d78490be553982a5f08503d4b4590
  Author: erbsland-dev <github at erbsland.dev>
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
    M doc/build.info
    A doc/man3/TS_VERIFY_CTX.pod
    R doc/man3/TS_VERIFY_CTX_set_certs.pod
    M util/libcrypto.num
    M util/other.syms

  Log Message:
  -----------
  Add and Update Documentation for TS_VERIFY_CTX Functions

Mark the existing `TS_VERIFY_CTX_set_certs` function as deprecated in the
documentation.
Add missing documentation for the deprecated functions `TS_VERIFY_CTX_set_data`,
`TS_VERIFY_CTX_set_imprint`, and `TS_VERIFY_CTX_set_store`.
Write missing documentation for the following functions:
- `TS_VERIFY_CTX_new`
- `TS_VERIFY_CTX_init`
- `TS_VERIFY_CTX_free`
- `TS_VERIFY_CTX_cleanup`
- `TS_VERIFY_CTX_set_flags`
- `TS_VERIFY_CTX_add_flags`
- `TS_VERIFY_CTX_set0_data`
- `TS_VERIFY_CTX_set0_imprint`
- `TS_VERIFY_CTX_set0_store`
- `TS_VERIFY_CTX_set0_certs`

Reviewed-by: Neil Horman <nhorman at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/24701)


Compare: https://github.com/openssl/openssl/compare/775188702574...2c1ef172f83d

To unsubscribe from these emails, change your notification settings at https://github.com/openssl/openssl/settings/notifications


More information about the openssl-commits mailing list