[openssl/openssl] 5c06b0: Fix line continuation check in config parser

Tobias Erbsland noreply at github.com
Tue Jul 16 19:34:58 UTC 2024


  Branch: refs/heads/openssl-3.2
  Home:   https://github.com/openssl/openssl
  Commit: 5c06b04a60adca451faca4e58bf2b59bd72e3f1e
      https://github.com/openssl/openssl/commit/5c06b04a60adca451faca4e58bf2b59bd72e3f1e
  Author: erbsland-dev <github at erbsland.dev>
  Date:   2024-07-16 (Tue, 16 Jul 2024)

  Changed paths:
    M crypto/conf/conf_def.c

  Log Message:
  -----------
  Fix line continuation check in config parser

Fixes #8038: Previously, line continuation logic did not account for the 'again' flag, which could cause incorrect removal of a backslash character in the middle of a line. This fix ensures that line continuation is correctly handled only when 'again' is false, thus improving the reliability of the configuration parser.

Reviewed-by: Neil Horman <nhorman at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/24890)

(cherry picked from commit f54e4bc51b78c10dc99a61c087861ee2c11d7a41)


  Commit: b0dd54fd127f96d60994b6b1a892ae66b46c70ee
      https://github.com/openssl/openssl/commit/b0dd54fd127f96d60994b6b1a892ae66b46c70ee
  Author: erbsland-dev <github at erbsland.dev>
  Date:   2024-07-16 (Tue, 16 Jul 2024)

  Changed paths:
    M test/recipes/04-test_conf.t
    A test/recipes/04-test_conf_data/oversized_line.cnf
    A test/recipes/04-test_conf_data/oversized_line.txt

  Log Message:
  -----------
  Add tests for long configuration lines with backslashes

Introduce new test files to verify behavior with config lines longer than 512 characters containing backslashes. Updated test plan to include these new test scenarios.

Reviewed-by: Neil Horman <nhorman at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/24890)

(cherry picked from commit 2dd74d3acb9425251a2028504f07623bd97bfe87)


Compare: https://github.com/openssl/openssl/compare/5bff33bf90b6...b0dd54fd127f

To unsubscribe from these emails, change your notification settings at https://github.com/openssl/openssl/settings/notifications


More information about the openssl-commits mailing list