[openssl/openssl] ed96c0: Fix coverity-1604665

Neil Horman noreply at github.com
Wed Jul 17 07:53:00 UTC 2024


  Branch: refs/heads/openssl-3.2
  Home:   https://github.com/openssl/openssl
  Commit: ed96c0ddfa0ecab9e8ec3f7f0407b92b07908528
      https://github.com/openssl/openssl/commit/ed96c0ddfa0ecab9e8ec3f7f0407b92b07908528
  Author: Neil Horman <nhorman at openssl.org>
  Date:   2024-07-17 (Wed, 17 Jul 2024)

  Changed paths:
    M apps/lib/opt.c

  Log Message:
  -----------
  Fix coverity-1604665

Coverity issued an error in the opt_uintmax code, detecting a potential
overflow on a cast to ossl_intmax_t

Looks like it was just a typo, casting m from uintmax_t to ossl_intmax_t

Fix it by correcting the cast to be ossl_uintmax_t, as would be expected

Theres also some conditionals that seem like they should be removed, but
I'll save that for later, as there may be some corner cases in which
ossl_uintmax_t isn't equal in size to uintmax_t..maybe.

Fixes openssl/private#567

Reviewed-by: Paul Dale <ppzgs1 at gmail.com>
Reviewed-by: Tom Cosgrove <tom.cosgrove at arm.com>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/24897)

(cherry picked from commit a753547eefc9739f341824a0cb0642afe7a06fcc)



To unsubscribe from these emails, change your notification settings at https://github.com/openssl/openssl/settings/notifications


More information about the openssl-commits mailing list