[openssl/openssl] 500662: Fix coverity-1604661

Neil Horman noreply at github.com
Thu Jul 18 17:09:59 UTC 2024


  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 50066236eb3b31c93aaa935ca38f5cc1ec056696
      https://github.com/openssl/openssl/commit/50066236eb3b31c93aaa935ca38f5cc1ec056696
  Author: Neil Horman <nhorman at openssl.org>
  Date:   2024-07-18 (Thu, 18 Jul 2024)

  Changed paths:
    M apps/asn1parse.c

  Log Message:
  -----------
  Fix coverity-1604661

Coverity called out an error in asn1parse_main, indicating that the
for(;;) loop which repeatedly reads from a bio and updates the length
value num, may overflow said value prior to exiting the loop.

We could probably call this a false positive, but on very large PEM
file, I suppose it could happen, so just add a check to ensure that num
doesn't go from a large positive to a large negative value inside the
loop

Fixes openssl/private#571

Reviewed-by: Tom Cosgrove <tom.cosgrove at arm.com>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/24910)



To unsubscribe from these emails, change your notification settings at https://github.com/openssl/openssl/settings/notifications


More information about the openssl-commits mailing list