[openssl/openssl] ec1d8e: Fix strtoul test on alpine/musl

Neil Horman noreply at github.com
Wed Jul 24 16:16:59 UTC 2024


  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: ec1d8ead2855f6cd529f9a1ace0a667f34eefc58
      https://github.com/openssl/openssl/commit/ec1d8ead2855f6cd529f9a1ace0a667f34eefc58
  Author: Neil Horman <nhorman at openssl.org>
  Date:   2024-07-24 (Wed, 24 Jul 2024)

  Changed paths:
    M test/strtoultest.c

  Log Message:
  -----------
  Fix strtoul test on alpine/musl

The strtoul tests that were recently added had a compile time check for
__WORDSIZE to properly determine the string to use for an maximal
unsigned long.  Unfortunately musl libc doesn't define __WORDSIZE so we
were in a position where on that platform we fall to the 32 bit unsigned
long variant, which breaks on x86 platforms.

Fix it by doing a preprocessor comparisong on ULONG_MAX instead.

NOTE: This works because preprocessors do arithmetic evaluation on
macros for every compiler we support.  We should be wary of some more
esoteric compilers though.

Reviewed-by: Matt Caswell <matt at openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove at arm.com>
(Merged from https://github.com/openssl/openssl/pull/24974)



To unsubscribe from these emails, change your notification settings at https://github.com/openssl/openssl/settings/notifications


More information about the openssl-commits mailing list