[openssl/openssl] 3190f5: Fix CRYPTO_atomic_store

Neil Horman noreply at github.com
Wed Jul 31 12:18:57 UTC 2024


  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 3190f5c06bd23ae4ddc659409e77070a6caa1539
      https://github.com/openssl/openssl/commit/3190f5c06bd23ae4ddc659409e77070a6caa1539
  Author: Neil Horman <nhorman at openssl.org>
  Date:   2024-07-31 (Wed, 31 Jul 2024)

  Changed paths:
    M crypto/threads_pthread.c

  Log Message:
  -----------
  Fix CRYPTO_atomic_store

If the implementation of this function falls to using a pthread lock to
update a value, it should be a write lock, not a read lock

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove at arm.com>
(Merged from https://github.com/openssl/openssl/pull/24969)


  Commit: 8e5cc43e74b32aca030a33e092b748addc564cd4
      https://github.com/openssl/openssl/commit/8e5cc43e74b32aca030a33e092b748addc564cd4
  Author: Neil Horman <nhorman at openssl.org>
  Date:   2024-07-31 (Wed, 31 Jul 2024)

  Changed paths:
    M crypto/hashtable/hashtable.c

  Log Message:
  -----------
  Make ossl_ht_delete use read-once semantics

To ensure that the value of h->md doesn't get recomputed during a delete
operation use ossl_rcu_deref on it

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove at arm.com>
(Merged from https://github.com/openssl/openssl/pull/24969)


  Commit: 9bd5e92aff83c24e0c6fdab1846340fae226dbb3
      https://github.com/openssl/openssl/commit/9bd5e92aff83c24e0c6fdab1846340fae226dbb3
  Author: Neil Horman <nhorman at openssl.org>
  Date:   2024-07-31 (Wed, 31 Jul 2024)

  Changed paths:
    M crypto/hashtable/hashtable.c

  Log Message:
  -----------
  Add error checking to CRYPTO_atomic_[load|store] calls

Noted that we didn't check return codes of the atomic loads/stores in
the new hashtable, and they can fail

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove at arm.com>
(Merged from https://github.com/openssl/openssl/pull/24969)


  Commit: 7408d58714e3235f58c4d7eba42207c83b55e6bd
      https://github.com/openssl/openssl/commit/7408d58714e3235f58c4d7eba42207c83b55e6bd
  Author: Neil Horman <nhorman at openssl.org>
  Date:   2024-07-31 (Wed, 31 Jul 2024)

  Changed paths:
    M crypto/threads_pthread.c

  Log Message:
  -----------
  disable rwlocks on nonstop klt model

It appears nonstops new threading model defines some level of rwlock
pthread api, but its not working properly.  Disable rwlocks for
_KLT_MODEL_ for now

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove at arm.com>
(Merged from https://github.com/openssl/openssl/pull/24969)


Compare: https://github.com/openssl/openssl/compare/454ca902c7d5...7408d58714e3

To unsubscribe from these emails, change your notification settings at https://github.com/openssl/openssl/settings/notifications


More information about the openssl-commits mailing list