[openssl/openssl] 3fc784: stricter parser for ipv4_from_asc

David Benjamin noreply at github.com
Mon Jun 24 13:44:53 UTC 2024


  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 3fc784835cdb8489117c2680e867cd32b3b70fbe
      https://github.com/openssl/openssl/commit/3fc784835cdb8489117c2680e867cd32b3b70fbe
  Author: David Benjamin <davidben at google.com>
  Date:   2024-06-24 (Mon, 24 Jun 2024)

  Changed paths:
    M crypto/x509/v3_utl.c
    M test/x509_internal_test.c

  Log Message:
  -----------
  stricter parser for ipv4_from_asc

reject invalid IPv4 addresses in ipv4_from_asc

The old scanf-based parser accepted all kinds of invalid inputs like:
"1.2.3.4.5"
"1.2.3.4 "
"1.2.3. 4"
" 1.2.3.4"
"1.2.3.4."
"1.2.3.+4"
"1.2.3.4.example.test"
"1.2.3.01"
"1.2.3.0x1"
Thanks to Amir Mohamadi for pointing this out.

Reviewed-by: Neil Horman <nhorman at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/24438)



To unsubscribe from these emails, change your notification settings at https://github.com/openssl/openssl/settings/notifications


More information about the openssl-commits mailing list