[openssl/tools] cb9d81: adjust newraw key to record time like the handshak...

Neil Horman noreply at github.com
Thu May 2 14:33:03 UTC 2024


  Branch: refs/heads/master
  Home:   https://github.com/openssl/tools
  Commit: cb9d8154dbb3cdbdf9d4225f9791da86d9a62a43
      https://github.com/openssl/tools/commit/cb9d8154dbb3cdbdf9d4225f9791da86d9a62a43
  Author: Neil Horman <nhorman at openssl.org>
  Date:   2024-04-30 (Tue, 30 Apr 2024)

  Changed paths:
    M perf/newrawkey.c

  Log Message:
  -----------
  adjust newraw key to record time like the handshake test

the handshake test records the average time of each thread running
its test, while other tests record the overall duration, leading to
inconsistencies in how we do measurement.

Bring newrawkey into line with how handshake does it.

Reviewed-by: Matt Caswell <matt at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/tools/pull/184)


  Commit: 8e82dd6faa516f212cede0008cf1fd7828453e5b
      https://github.com/openssl/tools/commit/8e82dd6faa516f212cede0008cf1fd7828453e5b
  Author: Neil Horman <nhorman at openssl.org>
  Date:   2024-04-30 (Tue, 30 Apr 2024)

  Changed paths:
    M perf/pemread.c

  Log Message:
  -----------
  convert pemread to be consistent in its time measurement

like handshake and newrawkey, record times per thread and average them

Reviewed-by: Matt Caswell <matt at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/tools/pull/184)


  Commit: bd3ad5fa870f4bfea1beccb116b908e555974b40
      https://github.com/openssl/tools/commit/bd3ad5fa870f4bfea1beccb116b908e555974b40
  Author: Neil Horman <nhorman at openssl.org>
  Date:   2024-04-30 (Tue, 30 Apr 2024)

  Changed paths:
    M perf/providerdoall.c

  Log Message:
  -----------
  Convert providerdoall to be consistent in time measurement

Convert it to do the same math the other tests do

Reviewed-by: Matt Caswell <matt at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/tools/pull/184)


  Commit: 3486229fa96bed8bbf4aa9e8f564236d9359f0d9
      https://github.com/openssl/tools/commit/3486229fa96bed8bbf4aa9e8f564236d9359f0d9
  Author: Neil Horman <nhorman at openssl.org>
  Date:   2024-04-30 (Tue, 30 Apr 2024)

  Changed paths:
    M perf/randbytes.c

  Log Message:
  -----------
  convert randbytes to use consistent time measurements

modify randbytes to measure time the way the other tests do

Reviewed-by: Matt Caswell <matt at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/tools/pull/184)


  Commit: 7efe27febfa3bc9ba526142e52dfe0b7fc64dceb
      https://github.com/openssl/tools/commit/7efe27febfa3bc9ba526142e52dfe0b7fc64dceb
  Author: Neil Horman <nhorman at openssl.org>
  Date:   2024-04-30 (Tue, 30 Apr 2024)

  Changed paths:
    M perf/rsasign.c

  Log Message:
  -----------
  make rsasign measure time consistently

Like the other tests, measure time per thread and average those

Reviewed-by: Matt Caswell <matt at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/tools/pull/184)


  Commit: 42debe8613e93c35ed5c53356bab9d728a1260fc
      https://github.com/openssl/tools/commit/42debe8613e93c35ed5c53356bab9d728a1260fc
  Author: Neil Horman <nhorman at openssl.org>
  Date:   2024-04-30 (Tue, 30 Apr 2024)

  Changed paths:
    M perf/sslnew.c

  Log Message:
  -----------
  convert sslnew to measure time consistently

Make it do the same math the other tests do

Reviewed-by: Matt Caswell <matt at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/tools/pull/184)


  Commit: 2db2bd1fc22cc077386cc73ec38982bcd87400d3
      https://github.com/openssl/tools/commit/2db2bd1fc22cc077386cc73ec38982bcd87400d3
  Author: Neil Horman <nhorman at openssl.org>
  Date:   2024-05-02 (Thu, 02 May 2024)

  Changed paths:
    M perf/newrawkey.c
    M perf/pemread.c
    M perf/providerdoall.c
    M perf/rsasign.c
    M perf/x509storeissuer.c

  Log Message:
  -----------
  make x509storeissuer do timekeeping like the other tests

Also, while I'm in here, fix an aliasing issue in threadcount, in which
the main routine had a variable overriding the global one.

Reviewed-by: Matt Caswell <matt at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/tools/pull/184)


  Commit: 58b7b94ae5f674e9665f9d9c816efa3c28fce4e6
      https://github.com/openssl/tools/commit/58b7b94ae5f674e9665f9d9c816efa3c28fce4e6
  Author: Neil Horman <nhorman at openssl.org>
  Date:   2024-05-02 (Thu, 02 May 2024)

  Changed paths:
    M perf/handshake.c
    M perf/newrawkey.c
    M perf/pemread.c
    M perf/providerdoall.c
    M perf/randbytes.c
    M perf/rsasign.c
    M perf/sslnew.c

  Log Message:
  -----------
  Convert all perf tools to not use ossl_time_divide

It looses information as its doing integer division

Reviewed-by: Matt Caswell <matt at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/tools/pull/184)


Compare: https://github.com/openssl/tools/compare/291a58020944...58b7b94ae5f6

To unsubscribe from these emails, change your notification settings at https://github.com/openssl/tools/settings/notifications


More information about the openssl-commits mailing list