[openssl/openssl] 5cb2a8: Add a test for the session_secret_cb

Matt Caswell noreply at github.com
Mon May 6 08:47:05 UTC 2024


  Branch: refs/heads/openssl-3.3
  Home:   https://github.com/openssl/openssl
  Commit: 5cb2a8fcc91b7b9bfffc70695df1bef29b495a60
      https://github.com/openssl/openssl/commit/5cb2a8fcc91b7b9bfffc70695df1bef29b495a60
  Author: Matt Caswell <matt at openssl.org>
  Date:   2024-05-06 (Mon, 06 May 2024)

  Changed paths:
    M test/sslapitest.c

  Log Message:
  -----------
  Add a test for the session_secret_cb

Ensure that if a session_secret_cb is being used that a connection can
be successfully made

Reviewed-by: Neil Horman <nhorman at openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit at gmail.com>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/24309)

(cherry picked from commit c8dddc61d49f84d1667de97e9548f07ccc92dddf)


  Commit: 9919027446dd8bb0cf5aad7d9580c32782f2d253
      https://github.com/openssl/openssl/commit/9919027446dd8bb0cf5aad7d9580c32782f2d253
  Author: Matt Caswell <matt at openssl.org>
  Date:   2024-05-06 (Mon, 06 May 2024)

  Changed paths:
    M ssl/statem/statem_srvr.c

  Log Message:
  -----------
  Set the server sig algs before calling the session_secret_cb

Setting the server sig algs sets up the certificate "s3->tmp.valid_flags".
These are needed when calling ssl3_choose_cipher() which can happen
immediately after calling the session_secret_cb

Fixes #24213

Reviewed-by: Neil Horman <nhorman at openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit at gmail.com>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/24309)

(cherry picked from commit 91c7ab27cebe4e6f6a6376e0a691736a2534fdd0)


  Commit: 5cd860825061dc8cb7ef666ea7ec8c51999a5553
      https://github.com/openssl/openssl/commit/5cd860825061dc8cb7ef666ea7ec8c51999a5553
  Author: Matt Caswell <matt at openssl.org>
  Date:   2024-05-06 (Mon, 06 May 2024)

  Changed paths:
    M doc/build.info
    A doc/man3/SSL_set_session_secret_cb.pod
    M util/missingssl.txt
    M util/other.syms

  Log Message:
  -----------
  Document the SSL_set_session_secret_cb() function

This function is only useful for EAP-FAST, but was previously undocumented.

Reviewed-by: Neil Horman <nhorman at openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit at gmail.com>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/24309)

(cherry picked from commit aecaaccaf93c4b36dd830accf08f2175059c5782)


  Commit: 287165f1b7ce0193378b9365e675edd69fc289c4
      https://github.com/openssl/openssl/commit/287165f1b7ce0193378b9365e675edd69fc289c4
  Author: Matt Caswell <matt at openssl.org>
  Date:   2024-05-06 (Mon, 06 May 2024)

  Changed paths:
    M ssl/ssl_sess.c

  Log Message:
  -----------
  Fix undefined behaviour in the event of a zero length session id

Don't attempt to memcpy a NULL pointer if the length is 0.

Reviewed-by: Neil Horman <nhorman at openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit at gmail.com>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/24309)

(cherry picked from commit 97c6489b39c966c6e5169b9b92ec5fa9a35c7ba3)


Compare: https://github.com/openssl/openssl/compare/168e49b5ab9e...287165f1b7ce

To unsubscribe from these emails, change your notification settings at https://github.com/openssl/openssl/settings/notifications


More information about the openssl-commits mailing list