[openssl/openssl] 27504d: Coverity found the following issues:

[Neil Horman]

  Branch: refs/heads/openssl-3.3
  Home:   https://github.com/openssl/openssl
  Commit: 27504de59586a23862f2f29e0d640b51d43ff24a
      https://github.com/openssl/openssl/commit/27504de59586a23862f2f29e0d640b51d43ff24a
  Author: Neil Horman <nhorman at openssl.org>
  Date:   2024-05-06 (Mon, 06 May 2024)

  Changed paths:
    M crypto/conf/conf_mod.c

  Log Message:
  -----------
  Coverity found the following issues:

1591471
1591474
1591476

which pertain to memory leaks in the conf_mod code

If an error is encountered after the module STACK_OF is duplicated or
created in the new_modules variable, we need to remember to free it in
the error path

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: Paul Dale <ppzgs1 at gmail.com>
(Merged from https://github.com/openssl/openssl/pull/24337)


  Commit: bc3e414939d804496fc77c0f5cf4b80eb4d8c6eb
      https://github.com/openssl/openssl/commit/bc3e414939d804496fc77c0f5cf4b80eb4d8c6eb
  Author: Neil Horman <nhorman at openssl.org>
  Date:   2024-05-06 (Mon, 06 May 2024)

  Changed paths:
    M test/threadstest.c

  Log Message:
  -----------
  Fix potential divide by zero error

Coverity caught the following issues:
1591477
1591475
1591473
1591470

all of which are simmilar, in that they catch potential divide by zero
in double values.  It can't actually happen since the the threads which
increment these counters don't exit until they reach non-zero values,
but its easy to add the checks, so lets do that to ensure that we don't
change something in the future that causes it.

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: Paul Dale <ppzgs1 at gmail.com>
(Merged from https://github.com/openssl/openssl/pull/24337)


Compare: https://github.com/openssl/openssl/compare/287165f1b7ce...bc3e414939d8

To unsubscribe from these emails, change your notification settings at https://github.com/openssl/openssl/settings/notifications