[openssl/openssl] 52313d: Fix mem leak in threadpool_test.c

[Hongren Zheng]

  Branch: refs/heads/openssl-3.3
  Home:   https://github.com/openssl/openssl
  Commit: 52313d342ee3e193c7e3bb115225fb3e67027b96
      https://github.com/openssl/openssl/commit/52313d342ee3e193c7e3bb115225fb3e67027b96
  Author: shridhar kalavagunta <coolshrid at hotmail.com>
  Date:   2024-05-20 (Mon, 20 May 2024)

  Changed paths:
    M test/threadpool_test.c

  Log Message:
  -----------
  Fix mem leak in threadpool_test.c

Fixes #24104

Added a goto label for cleanup.

Reviewed-by: Paul Dale <ppzgs1 at gmail.com>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/24412)

(cherry picked from commit 4dbd4925dfc61d93df678df607504f62b0ac3dcc)


  Commit: bc73967d3a7d73a2242022c89f4f324ada87e47c
      https://github.com/openssl/openssl/commit/bc73967d3a7d73a2242022c89f4f324ada87e47c
  Author: Hongren Zheng <i at zenithal.me>
  Date:   2024-05-20 (Mon, 20 May 2024)

  Changed paths:
    M providers/fips/fipsprov.c

  Log Message:
  -----------
  fips provider: explicitly setup cpuid when initializing

Fixes: #23979

Previously fips module relied on OPENSSL_cpuid_setup
being used as constructor by the linker to correctly
setup the capability vector, either via .section .init
(for x86_64) or via __attribute__((constructor)).

This would make ld.so call OPENSSL_cpuid_setup before
the init function for fips module. However, this early
constructing behavior has several disadvantages:

1. Not all platform/toolchain supports such behavior

2. Initialisation sequence is not well defined, and
some function might not be initialized when cpuid_setup
is called

3. Implicit path is hard to maintain and debug

Reviewed-by: Paul Dale <ppzgs1 at gmail.com>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/24419)

(cherry picked from commit a192b2439c0207ce1b04ba6137329b68f9e23680)


Compare: https://github.com/openssl/openssl/compare/9baa68b12877...bc73967d3a7d

To unsubscribe from these emails, change your notification settings at https://github.com/openssl/openssl/settings/notifications