[openssl/openssl] 4dbd49: Fix mem leak in threadpool_test.c

Richard Levitte noreply at github.com
Wed May 22 11:28:25 UTC 2024


  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 4dbd4925dfc61d93df678df607504f62b0ac3dcc
      https://github.com/openssl/openssl/commit/4dbd4925dfc61d93df678df607504f62b0ac3dcc
  Author: shridhar kalavagunta <coolshrid at hotmail.com>
  Date:   2024-05-20 (Mon, 20 May 2024)

  Changed paths:
    M test/threadpool_test.c

  Log Message:
  -----------
  Fix mem leak in threadpool_test.c

Fixes #24104

Added a goto label for cleanup.

Reviewed-by: Paul Dale <ppzgs1 at gmail.com>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/24412)


  Commit: a192b2439c0207ce1b04ba6137329b68f9e23680
      https://github.com/openssl/openssl/commit/a192b2439c0207ce1b04ba6137329b68f9e23680
  Author: Hongren Zheng <i at zenithal.me>
  Date:   2024-05-20 (Mon, 20 May 2024)

  Changed paths:
    M providers/fips/fipsprov.c

  Log Message:
  -----------
  fips provider: explicitly setup cpuid when initializing

Fixes: #23979

Previously fips module relied on OPENSSL_cpuid_setup
being used as constructor by the linker to correctly
setup the capability vector, either via .section .init
(for x86_64) or via __attribute__((constructor)).

This would make ld.so call OPENSSL_cpuid_setup before
the init function for fips module. However, this early
constructing behavior has several disadvantages:

1. Not all platform/toolchain supports such behavior

2. Initialisation sequence is not well defined, and
some function might not be initialized when cpuid_setup
is called

3. Implicit path is hard to maintain and debug

Reviewed-by: Paul Dale <ppzgs1 at gmail.com>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/24419)


  Commit: 34f35473c06a91b82ce65cae952405a1bdb04dac
      https://github.com/openssl/openssl/commit/34f35473c06a91b82ce65cae952405a1bdb04dac
  Author: Richard Levitte <levitte at openssl.org>
  Date:   2024-05-22 (Wed, 22 May 2024)

  Changed paths:
    M .github/workflows/ci.yml

  Log Message:
  -----------
  Work on ANSI C compatibility: modifying the github workflow

The github workflow that attempts to check that OpenSSL ANSI C compatible
defined '_DEFAULT_SOURCE', which effectively turns gcc and clang into a C99
compiler...  perhaps not with regard to pure language features, but it enables
a few too many types and functions that aren't defined in ANSI C library, or
in some cases, in any C language level library.

Instead of '_DEFAULT_SOURCE', this modification defines '_XOPEN_SOURCE=1' and
'_POSIX_SOURCE=200809L', to enable the use of 'timezone', 'ssize_t' and 'strdup()'.

Reviewed-by: Tom Cosgrove <tom.cosgrove at arm.com>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/24173)


  Commit: f352c808edaaced8ba6a95cb440825094f2bb842
      https://github.com/openssl/openssl/commit/f352c808edaaced8ba6a95cb440825094f2bb842
  Author: Richard Levitte <levitte at openssl.org>
  Date:   2024-05-22 (Wed, 22 May 2024)

  Changed paths:
    M crypto/sleep.c
    M util/platform_symbols/unix-symbols.txt

  Log Message:
  -----------
  For Unix, refactor OSSL_sleep() to use nanosleep() instead of usleep()

usleep() is obsolete since POSIX.1-2001 and removed in POSIX.1-2008,
in favor of nanosleep(), which has been present since POSIX.1-2001.

The exceptions for DJGPP and TANDEM are preserved.  Also, just in case
nanosleep() turns out to be unavailable on any Unix machinery that we
are unaware of, we allow a revert to using usleep() by defining
OPENSSL_USE_USLEEP.

Reviewed-by: Tom Cosgrove <tom.cosgrove at arm.com>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/24173)


  Commit: 8cf9ac9c2034eb383b72bb7a849b5db96ff593f6
      https://github.com/openssl/openssl/commit/8cf9ac9c2034eb383b72bb7a849b5db96ff593f6
  Author: Richard Levitte <levitte at openssl.org>
  Date:   2024-05-22 (Wed, 22 May 2024)

  Changed paths:
    M include/openssl/e_os2.h

  Log Message:
  -----------
  When defining ossl_ssize_t = ssize_t, remember to include sys/types.h

ssize_t isn't a C language type in any C language level, but is a POSIX type
defined in <sys/types.h>, so make sure to include that before use.

Reviewed-by: Tom Cosgrove <tom.cosgrove at arm.com>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/24173)


  Commit: 4e8c4b77ef7480b80de1971d8862300c366015e9
      https://github.com/openssl/openssl/commit/4e8c4b77ef7480b80de1971d8862300c366015e9
  Author: Richard Levitte <levitte at openssl.org>
  Date:   2024-05-22 (Wed, 22 May 2024)

  Changed paths:
    M INSTALL.md
    A NOTES-ANSI.md
    A NOTES-POSIX.md

  Log Message:
  -----------
  Add installation documentation and notes on ANSI C and POSIX

Reviewed-by: Tom Cosgrove <tom.cosgrove at arm.com>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/24173)


Compare: https://github.com/openssl/openssl/compare/45f5d51b72a2...4e8c4b77ef74

To unsubscribe from these emails, change your notification settings at https://github.com/openssl/openssl/settings/notifications


More information about the openssl-commits mailing list