[openssl-dev] [openssl.org #3787] [PATCH] Update the return value documentation for various EVP_* functions to match the code.

Laetitia Baudoin via RT rt at openssl.org
Wed Apr 8 15:19:59 UTC 2015


Update the documented return values for the EVP_DigestVerifyInit,
EVP_DigestVerifyUpdate, EVP_CIPHER_param_to_asn1 and
EVP_CIPHER_asn1_to_param so they match the code.

Justification:
EVP_CIPHER_param_to_asn1: returns -1 on failure and 1 or the size of the IV
on success.
https://github.com/openssl/openssl/blob/master/crypto/evp/evp_lib.c#L64

EVP_CIPHER_asn1_to_param: returns -1 on failure or 1 or the size of the IV
on success (checked also with the RC2 ASN.1 parameter parsing).
https://github.com/openssl/openssl/blob/master/crypto/evp/evp_lib.c#L81

EVP_DigestVerifyInit only returns 0 on failure or 1 on success:
https://github.com/openssl/openssl/blob/master/crypto/evp/m_sigver.c#L116

EVP_DigestVerifyUpdate is #defined to EVP_DigestUpdate that is already
documented to return 1 for success or 0 for failure
Typedef location
https://github.com/openssl/openssl/blob/master/include/openssl/evp.h#L589

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-the-EVP_DigestVerifyInit-EVP_DigestVerifyUpdate-.patch
Type: text/x-patch
Size: 1699 bytes
Desc: not available
URL: <http://mta.openssl.org/pipermail/openssl-dev/attachments/20150408/1c4f0367/attachment.bin>


More information about the openssl-dev mailing list