[openssl-dev] [openssl.org #4138] Detection of assembler version
Andy Polyakov via RT
rt at openssl.org
Wed Dec 2 14:36:19 UTC 2015
>>> I just found out that building with at least with the French
>>> locale the AVX code is missing. The problem is this code in
>>> crypto/sha/asm/sha1-x86_64.pl:
>>> if (`$ENV{CC} -Wa,-v -c -o /dev/null -x assembler /dev/null 2>&1`
>>> =~ /GNU assembler version ([2-9]\.[0-9]+)/) {
>>> $avx = ($1>=2.19) + ($1>=2.22);
>>> }
>>>
>>> In English it returns:
>>> GNU assembler version 2.25.1 (x86_64-linux-gnu) using BFD version (GNU Binutils for Debian) 2.25.1
>>>
>>> But in French it returns:
>>> Version de l'assembleur GNU 2.25.1 (x86_64-linux-gnu) utilisant la version BFD (GNU Binutils for Debian) 2.25.1
>>>
>>> A quick grep at least shows 17 affected files.
>>>
>>> The fix should be easy setting the locale to C when doing that
>>> check.
>>
>> Oh! Though I'd like to suggest taking it even further. Namely setting
>> LANG to C in top-most Makefile. This way we would also ensure that even
>> compiler error messages are readable when reported. What do you think?
>>
>> (I wish one could do something like that even with Microsouple
>> l'compilateur ;-)
>
> Just a small addition: LANG gets overwritten by LC_* and LC_* gets
> overwritten by LC_ALL. So it would be strongest to set LC_ALL, not LANG.
LC_ALL it is. Closing.
More information about the openssl-dev
mailing list