[openssl-dev] [openssl.org #4144] patch: Use '__sun' instead of 'sun' for strict ISO conforming, compiler/options

Andy Polyakov via RT rt at openssl.org
Wed Dec 2 14:59:38 UTC 2015


>> ... Either way, we seem to
>> agree that *replacing* sun with __sun is not right thing to do in SunOS
>> 4 context. One can argue for sun || __sun, or one can argue in favour of
>> reverting. My vote goes for latter, because original conditions [in
>> e_os.h] do work adequately.
> 
> After closer look I have to withdraw my preference for just reverting.
> Because there is one case that is not appropriate for *Solaris*.
> Initially I noted that Solaris sys/ioctl.h includes sys/filio.h, but I
> failed to notice and latter's inclusion is conditional and condition is
> not met when OpenSSL compiles with defaults flags. As compiler targeting
> Solaris doesn't *have to* define 'sun' for system headers to work, one
> has to reserve for possibility that it's absent.

Fixed. Closing.





More information about the openssl-dev mailing list